Faulty assumption that all users have $home in /Users in SplashBuddy.launch.sh

[jby]

The file /Library/Application\ Support/SplashBuddy/SplashBuddy.launch.sh assumes that whatever user is the $loggedInUser has its $home in /Users/$user:

doneFile="/Users/${loggedInUser}/Library/Containers/io.fti.SplashBuddy/Data/Library/.SplashBuddyDone"

Hidden users have their $home in /var/$user which makes the .SplashBuddyDone-file impossible to find for such a user - making SplashBuddy respawn indefinitely regardless of its existens.

[jby]

Workaround:

sudo mkdir -p /Users/$user/Library/Containers/io.fti.SplashBuddy/Data/Library/
sudo touch /Users/$user/Library/Containers/io.fti.SplashBuddy/Data/Library/.SplashBuddyDone

[canalnoises]

I think my pull request (above) addresses this issue. I added a $homeDir variable that is populated by the home directory as pulled from dscl...

homeDir=$(/usr/bin/dscl . read /Users/${loggedInUser} NFSHomeDirectory | /usr/bin/awk '{print $2}')

...and changed the path in $doneFile to use ${homeDir} instead of /Users/${loggedInUser}.