Skip to content
This repository has been archived by the owner on Feb 8, 2023. It is now read-only.

Finds user's home directory with dscl (Issue #73) #124

Closed
wants to merge 1 commit into from
Closed

Finds user's home directory with dscl (Issue #73) #124

wants to merge 1 commit into from

Conversation

canalnoises
Copy link

Fix for Issue #73 where SplashBuddy incorrectly assumes that users that have their home directory in /Users.

Adds compatibility for users that have their home directory in a non-standard location.
@ygini ygini closed this Nov 15, 2020
@ygini ygini deleted the branch macadmins:master November 15, 2020 07:50
@canalnoises
Copy link
Author

@ygini can you tell me why my pull request was closed without merging it into master? I've been using this fix in my environment for over a year and it works great. It solves a problem that others were experiencing (see issue #73) so I thought this would be a shoe-in. Just curious 🤷🏼‍♂️

@ygini
Copy link
Member

ygini commented Nov 16, 2020

Hello

The PR got closed automatically because of the branch deletion. Sorry for that.

Your change request however is completely legitimate.

Can you re-do your PR from a fork of the last main branch? We did a lot of code changes in SplashBuddy recently, on multiple different forks and with maintainer move. This caused a lot of trouble to reintegrate all changes. Sorry for that.

@canalnoises
Copy link
Author

Oh, no worries. I'll redo it. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants