Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taco: new port in math #17154

Closed
wants to merge 1 commit into from
Closed

Conversation

barracuda156
Copy link
Contributor

@barracuda156 barracuda156 commented Jan 1, 2023

Description

New port: https://github.com/tensor-compiler/taco

Tests mostly pass on 10.6.8 x86_64:

99% tests passed, 2 tests failed out of 231

Total Test time (real) = 294.20 sec

The following tests did not run:
	 43 - expr.accumulate (Disabled)
	 55 - format.mm_permute_formats (Disabled)
	101 - qcd.mul3 (Disabled)
	127 - generate_evaluation_files.cpu (Disabled)
	128 - generate_evaluation_files.gpu (Disabled)
	129 - generate_figures.cpu (Disabled)
	130 - scheduling_eval.bfsPullScheduled (Disabled)
	193 - tensor_types.complex_mul_scalar (Disabled)
	198 - tensor_types.coordinate_types (Disabled)
	204 - lower.transpose (Disabled)
	205 - lower.transpose2 (Disabled)
	206 - lower.transpose3 (Disabled)

The following tests FAILED:
	 99 - qcd.mul1 (Failed)
	243 - taco-cli-test (Failed)
Errors while running CTest

PPC does not work presently: tensor-compiler/taco#541 (malloc errors, and adding DYDL_LIBRARY_PATH to test.env fails to help, whether directly or via legacysupport PG).

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6.8 Server
Xcode 3.2.6

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@barracuda156 barracuda156 marked this pull request as ready for review January 1, 2023 13:13
@barracuda156 barracuda156 marked this pull request as draft January 20, 2023 23:05
@barracuda156
Copy link
Contributor Author

Let me see if something can be done for PPC first.

@mascguy mascguy marked this pull request as ready for review May 28, 2023 14:55
@mascguy
Copy link
Member

mascguy commented May 28, 2023

Let me see if something can be done for PPC first.

Don't forget this PR too...

@barracuda156
Copy link
Contributor Author

Let me see if something can be done for PPC first.

Don't forget this PR too...

I was discussing with upstream in a hope to get some advice, but apparently we are on our own here: tensor-compiler/taco#541

Of course we could merge this first with a note that PPC needs fixes, but given that nothing depends on this port, I would rather give myself some extra time to see if PPC is fixable. I will try to get to this, say, within a week.
But I am also okay with merging now and fixing PPC a bit later, no issues.

@reneeotten
Copy link
Contributor

@barracuda156 where are we with this?

@barracuda156
Copy link
Contributor Author

@reneeotten Please keep this alive. In the process, let me do an update for upstream issue tomorrow.

In the meanwhile, could you help to merge PRs which are long back ready? I would also appreciate a clean-up and have only unfinished PRs open.

@reneeotten
Copy link
Contributor

like which PRs do you consider ready?

@barracuda156
Copy link
Contributor Author

barracuda156 commented Aug 13, 2023

like which PRs do you consider ready?

@reneeotten Well, there is a huge queue:

#19751
#19716
#19629
#19527
#19387
#19319
#18920
#18792
#18786
#18103

@mascguy mascguy marked this pull request as draft August 20, 2023 11:51
@pmetzger
Copy link
Member

So all of those are merged. Can we close this? @barracuda156 closing a PR doesn't mean the update is dead. It just means no one but the person working on it is expected to spend time on it. If stuff is sitting in the queue, people are supposed to be checking on it and shepherding it through. If you have a private queue of things you're working on and that others shouldn't be thinking about, those should be in your repo. The PR queue is really for things we think are ready to work on and get committed.

@reneeotten reneeotten closed this Nov 22, 2023
@barracuda156
Copy link
Contributor Author

@pmetzger @reneeotten Yeah, sure. I will return to it, I hope, but it is fine to close it atm.
I am travelling presently, so away from PPC and x86 hardware and somewhat short on time too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants