Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lean: update to 3.51.1 #25588

Merged
merged 1 commit into from
Sep 5, 2024
Merged

lean: update to 3.51.1 #25588

merged 1 commit into from
Sep 5, 2024

Conversation

barracuda156
Copy link
Contributor

Description

Update, drop arch restriction

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6
Xcode 3.2

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@kakuhen for port lean.

@barracuda156
Copy link
Contributor Author

No idea why this was set to x86_64 arm64, I built this with zero fixes added and got 1 test case failure:

99% tests passed, 1 tests failed out of 1441

Total Test time (real) = 1149.99 sec

The following tests FAILED:
	1366 - leanittest_complete_trailing_period.lean (Failed)

Issue for the test case: leanprover-community/lean#816

@pmetzger
Copy link
Member

pmetzger commented Sep 3, 2024

LGTM. @kakuhen?

@pmetzger
Copy link
Member

pmetzger commented Sep 3, 2024

BTW, I have certain suspicions that the maintainer might not actually be maintaining anything given the lack of an email address; if they time out, you might file a Port Abandoned.

@pmetzger pmetzger merged commit 25ba14f into macports:master Sep 5, 2024
3 checks passed
@pmetzger
Copy link
Member

pmetzger commented Sep 5, 2024

See above.

@barracuda156 barracuda156 deleted the lean branch September 6, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants