Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoconf: fix Linux build #25610

Merged
merged 3 commits into from
Oct 23, 2024
Merged

autoconf: fix Linux build #25610

merged 3 commits into from
Oct 23, 2024

Conversation

barracuda156
Copy link
Contributor

Closes: https://trac.macports.org/ticket/70673

Description

Non-macOS-only:

Use MacPorts perl5 on non-Darwin systems.
Also it may need help2man.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

Linux riscv64

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@larryv for port autoconf.

@barracuda156
Copy link
Contributor Author

If there are any objections, I do not insist on anything for Linux, but this does fix the issue for me.

depends_build-append \
port:help2man
# https://trac.macports.org/ticket/70673
configure.perl ${prefix}/bin/perl5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

help2man depends on perl5.34. perl5.34 provides the perl5.34 executable. The perl5 symlink is provided by the perl5 port. If you want to use the perl5 symlink here you have to depend on the perl5 port.

@reneeotten
Copy link
Contributor

ping @barracuda156 - please address the comment by @ryandesign

@barracuda156
Copy link
Contributor Author

@reneeotten @ryandesign Yeah, will do this tomorrow. Sorry for a delay, Linux is not really a priority, but I want basic ports to work.

@barracuda156
Copy link
Contributor Author

@reneeotten Done, sorry for a delay here.

@reneeotten
Copy link
Contributor

@reneeotten Done, sorry for a delay here.

You mixed up two changes in the last commit and the commit message does not reflect that. The "perl5" dependency for "autoconf" should go in the first commit.

@reneeotten reneeotten merged commit 65ce212 into macports:master Oct 23, 2024
4 checks passed
@barracuda156 barracuda156 deleted the autoconf branch October 23, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants