Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sketchybar: update to 2.21.0 #26000

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

tsujp
Copy link
Contributor

@tsujp tsujp commented Sep 29, 2024

Description

update sketchybar to latest release.

Tested on

macOS 14.5 23F79 arm64
Command Line Tools 15.3.0.0.1.1708646388

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@bashu for port sketchybar.

@macportsbot macportsbot added type: update maintainer: open Affects an openmaintainer port labels Sep 29, 2024
@ryandesign
Copy link
Contributor

This appears to be installing a universal binary even when that was not requested. It needs to install only for the architectures MacPorts tells it to.

@tsujp
Copy link
Contributor Author

tsujp commented Oct 12, 2024

Unsure why, will have a look.

@reneeotten
Copy link
Contributor

ping

@tsujp
Copy link
Contributor Author

tsujp commented Oct 20, 2024

@ryandesign still unsure but I see a lot of other ports with the same (pnpm, yabai, and so forth).

@reneeotten
Copy link
Contributor

If you look at the makefile you will see that the default target all refers to universal so that's the reason. There are other targets like x86 and arm64 which you should use depending on which systems it's building for.

@reneeotten
Copy link
Contributor

with the commit I added it will build only for the requested architecture (i.e., arm64 or x86_64). I am not completely sure about the correct syntax for a universal build, and cannot test this locally I think... @ryandesign would. you mind taking a quick look before we merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: update
Development

Successfully merging this pull request may close these issues.

4 participants