emacs-app-devel: update to 20241021 #26002
Conversation
tsujp
force-pushed
the
port/emacs-app-devel
branch
from
c3987bf
to
13d80ac
Compare
editors/emacs/Portfile
Outdated
| epoch 5 | ||
| version 20240804 | ||
| github.setup emacs-mirror emacs a06a7209028363a1bb2f727ffaecdf4d02296b2e | ||
| epoch 1 |
There was a problem hiding this comment.
the epoch field can never decrease, it should stay at 5 (see the guide)
There was a problem hiding this comment.
Whoops, I really should try find my MacPorts notes again.
There was a problem hiding this comment.
I'm going to bump it to 6 so it guaranteed invalidates prior versions.
There was a problem hiding this comment.
no, don't do that. You updates the version so there is absolutely no need to do so. The only reason to increase the "epoch" is when you want to downgrade the version or of the versioning has changed so that a newer version isn't recognized as newer by "vercomp".
Please refer to the guide entry O linked.
There was a problem hiding this comment.
I was doing so just in-case as I had a brain fart and thought it also compared the commit hash (late and very tired). I did read the link you sent before acting hehe. I'll set it back to 5.
| depends_lib-delete port:jansson | ||
| configure.args-append --with-native-compilation=no | ||
|
|
||
| # TODO: Put this somewhere better. See https://github.com/emacs-mirror/emacs/commit/4c6f45fa8eef1a15d5790c1f3d3e608b548015db#diff-731c852b7c27c6ee90c44c871e2988ecfc2d225bc720156d7a47c1d563c2683aR59 |
There was a problem hiding this comment.
what is the purpose of this comments; what would be a better place to put it? And if there is such a place why not do it now?
There was a problem hiding this comment.
Ah yes. Do you want this as a new variant option or always present by default? The linked comment:
** New configuration option '--disable-gc-mark-trace'.
This disables the GC mark trace buffer for about 5 % better garbage
collection performance. Doing so may make it more difficult for Emacs
developers to help finding GC-related bugs that you run into, which is
why it the mark trace buffer is enabled by default.
There was a problem hiding this comment.
well, it depends - do you think many users will be "Emacs developers" as that seems to be the usual situation where you might not want to have it disabled. I would probably have it use this configure.arg always; if @drkp has a different opinion he can always change it and/or put it in a variant.
|
@reneeotten I've updated the devel version to 20241021 master HEAD |
tsujp
changed the title
| if {[variant_isset nativecomp]} { | ||
| notes "emacs devel subports don't always keep compatibility for native\ | ||
| compiled files. Better to cleanup your ~/.emacs.d/.local/cache/eln" | ||
|
|
||
| configure.args-delete --with-native-compilation=no | ||
| configure.args-append --with-native-compilation=aot |
There was a problem hiding this comment.
this could/should use configure.args-replace instead
There was a problem hiding this comment.
Will get to it, going to wait for @drkp's feedback for the other item in this file (do both at once).
There was a problem hiding this comment.
Just finish it up. None of the maintainers has responded in over three weeks, so don't wait. Just get these last things finalized and I'll merge it.
There was a problem hiding this comment.
Alrighty, will get on it in an hour or two.
| depends_lib-delete port:jansson | ||
| configure.args-append --with-native-compilation=no | ||
|
|
||
| # TODO: Put this somewhere better. See https://github.com/emacs-mirror/emacs/commit/4c6f45fa8eef1a15d5790c1f3d3e608b548015db#diff-731c852b7c27c6ee90c44c871e2988ecfc2d225bc720156d7a47c1d563c2683aR59 |
There was a problem hiding this comment.
well, it depends - do you think many users will be "Emacs developers" as that seems to be the usual situation where you might not want to have it disabled. I would probably have it use this configure.arg always; if @drkp has a different opinion he can always change it and/or put it in a variant.
Description
This is a weird one I think since I have chosen to specifically only update emacs-app-devel which also has differing compilation flags (native compilation is now default for example).
As and when Emacs 30 gets released I imagine the Portfile will get simpler, I've been using this general structure since August rebuilding from Emacs' master every other week or so.
Tested on
macOS 14.5 23F79 arm64
Command Line Tools 15.3.0.0.1.1708646388
Verification
Have you
port lint --nitpick?sudo port test?sudo port -vst install?