Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghidra: enable native file picker and menubar #26132

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

crowell
Copy link
Contributor

@crowell crowell commented Oct 10, 2024

Description

add variants nativefilepicker and nativemenubar to use native file picker widget, and native macos menubar.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 15.0.1 24A348 arm64
Xcode 16.0 16A242d

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • checked your Portfile with port lint --nitpick?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@hexagonal-sun for port ghidra.

@crowell
Copy link
Contributor Author

crowell commented Oct 10, 2024

should have fixed the permissions error, rerunning the CI
edit: CI worked, ready to go :)

@reneeotten
Copy link
Contributor

@crowell any obvious reason why one would need to have this enabled by default and thus unconditionally without the addition of variants?

@crowell
Copy link
Contributor Author

crowell commented Oct 14, 2024

@reneeotten they're mostly Quality Of Life improvements for the UI. I can make them non-default if that is the macports philosophy. It's just most people I know/have talked to prefer these small patches for ghidra. Let me know and I can switch it to non-default if that's more desirable.

@reneeotten
Copy link
Contributor

what I meant is: why add them as variants. If they are useful for end-user I think it would be preferable to just add these things unconditionally to the Portfile. In other words, no need for variants - as I don't really see an obvious reason why someone would bot want to have this.

Variants are primarily intended for additional functionality that some people might want but would come, for example, with "heavy" dependents and thus it would be beneficial to give end-users a choice.

@crowell
Copy link
Contributor Author

crowell commented Oct 15, 2024

ah, makes sense! changing to be default.

@crowell crowell changed the title ghidra: add variant to enable native file picker and menubar ghidra: enable native file picker and menubar Oct 15, 2024
@reneeotten reneeotten merged commit 49b17b2 into macports:master Oct 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants