Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the range of motion (max. orientation change) to the list of spatial parameters. #54

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

AKuederle
Copy link
Member

No description provided.

@AKuederle
Copy link
Member Author

@HaMora Any updates on this?

@HaMora
Copy link
Collaborator

HaMora commented Mar 22, 2024

Hi @AKuederle,
Can we have a short talk about this next week? I really wanna know the underlying work for the tests and the snapshots that we have.
As far as I understand, the test fails since we need a new snapshot with the new parameter. Which, honestly; I didn't spend much time as well to figure out how to create them :)

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.58%. Comparing base (b7139d9) to head (6bd7a86).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   91.56%   91.58%   +0.01%     
==========================================
  Files          61       61              
  Lines        3297     3303       +6     
==========================================
+ Hits         3019     3025       +6     
  Misses        278      278              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HaMora
Copy link
Collaborator

HaMora commented Apr 18, 2024

Hi @AKuederle,
I have fixed the tests and replaced the snapshots (thank you for the explanations).
I just don't know why the docs test failed.

Copy link
Member Author

@AKuederle AKuederle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me @HaMora Can you add a Changelog entry (see CHANGELOG.md). Just add a new secition called unreleased at the top, quickly describe the change and add a link to this PR

gaitmap/parameters/_spatial_parameters.py Outdated Show resolved Hide resolved
@AKuederle AKuederle merged commit f16ab17 into master Apr 19, 2024
8 checks passed
@AKuederle AKuederle deleted the max_orientation_movement branch April 19, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants