Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: readability and maintainability #121

Merged
merged 6 commits into from
Jul 6, 2024
Merged

Conversation

jkowalleck
Copy link
Collaborator

@jkowalleck jkowalleck commented Jul 6, 2024

  • xml bool values were static simplified
  • dict.update() were replaced by proper access methods dict[]
  • set simplify

the aim is to improve readability and maintainability

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the refactor/this_and_that branch from 8c5dc0a to 633441a Compare July 6, 2024 11:50
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck marked this pull request as ready for review July 6, 2024 14:45
@jkowalleck jkowalleck requested a review from madpah as a code owner July 6, 2024 14:45
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck merged commit 73ce317 into main Jul 6, 2024
18 checks passed
@jkowalleck jkowalleck deleted the refactor/this_and_that branch July 6, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant