fix: date/time deserialization with fractional seconds #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ILikeToFixThings
requested review from
madpah and
jkowalleck
as code owners
jkowalleck
requested changes
Sep 30, 2024
jkowalleck
reviewed
Oct 1, 2024
jkowalleck
requested changes
Oct 1, 2024
jkowalleck
changed the title
jkowalleck
requested changes
Oct 1, 2024
jkowalleck
requested changes
Oct 1, 2024
|
tried to consolidate the python 3.11 compatibility layer via 72ce000 |
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck
approved these changes
Oct 1, 2024
|
@ILikeToFixThings I did a consolidation of your changes. could you review? |
|
@madpah could I ask you for a review? |
Looks good to me! |
madpah
approved these changes
Oct 1, 2024
|
Thank you so much for bringing this issue up and providing fixes for it. Your work resulted in the published release: https://github.com/madpah/serializable/releases/tag/v1.1.2 |
|
And thanks too @jkowalleck ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Currently on Python 3.10 and earlier there is an exception thrown if you try to parse a JSON file with more than 6 fractional seconds (the decimals) in a JSON file. ISO8601 datetimes are allowed to have any number of fractional seconds but the regex fix applied by this library to allow Python to parse ISO8601 timestamps that is needed pre Python 3.11 due to weirdness around Pythons ISO parsing requiring either 0 or 6 fractional seconds currently only pads the fractional seconds if required and does not truncate if the timestamp is too long which was causing me issues parsing a JSON SBOM file generated by cargo-cyclonedx which includes 9 decimal places on its timestamp for some reason. This is only an issue pre Python 3.11 since in 3.11 they made
datetime.fromisoformatISO compliant.I have added some tests which showcase the issue and applied a fix to the padding code of datetime deserialization.