feat: enhanced typehints and typing #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkowalleck
force-pushed
the
fix/typehints-attempt1
branch
6 times, most recently
from
e36f4e8 to
ebd5bae
Compare
jkowalleck
changed the title
jkowalleck
force-pushed
the
fix/typehints-attempt1
branch
from
ebd5bae to
3ae2d51
Compare
jkowalleck
force-pushed
the
fix/typehints-attempt1
branch
from
809b289 to
56c0b82
Compare
jkowalleck
changed the title
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck
force-pushed
the
fix/typehints-attempt1
branch
from
3a6dd8d to
b4052b9
Compare
jkowalleck
commented
Oct 6, 2023
| @@ -50,15 +58,14 @@ | |||
| logger.setLevel(logging.INFO) | |||
|
|
|||
|
|
|||
| class _Klass(Protocol): | |||
| __name__: str | |||
There was a problem hiding this comment.
these are properties of type, not intended class properties.
jkowalleck
commented
Oct 6, 2023
|
|
||
|
|
||
| _F = TypeVar("_F", bound=Callable[..., Any]) | ||
| _T = TypeVar('_T', bound=_Klass) | ||
|
|
||
| ViewType = _Klass |
There was a problem hiding this comment.
at runtime, _Klass/ViewType was just any class. so this stays as is ...
but the typing was intended to glook tof a type of _Klass/ViewType ...
this is fixed, now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even tough some structures are refactored, no public API is changed.
No runtime is changed.
TypeCheckers might behave differently, which is intentional due to bug fixes. This is considered a non-breaking change, as it does not affect runtime.