tests to reproduce #89 #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Horton <paul.horton@owasp.org>
…es not conform to current formatter Signed-off-by: Paul Horton <paul.horton@owasp.org>
Signed-off-by: Paul Horton <paul.horton@owasp.org>
Signed-off-by: Paul Horton <paul.horton@owasp.org>
Signed-off-by: Paul Horton <paul.horton@owasp.org>
jkowalleck
reviewed
Apr 4, 2024
| for p, pi in klass_properties.items(): | ||
| if pi.xml_array_config: | ||
| array_type, nested_name = pi.xml_array_config | ||
| if nested_name == strip_default_namespace(child_e.tag): |
There was a problem hiding this comment.
The strip_default_namespace(child_e.tag) is as constant as it gets through all these nested loops.
Better calculate the value upfront, instead of each time the loop is processed.
| @@ -557,6 +557,14 @@ def strip_default_namespace(s: str) -> str: | |||
| # Handle Sub-Elements | |||
| for child_e in data: | |||
| decoded_k = CurrentFormatter.formatter.decode(strip_default_namespace(child_e.tag)) | |||
|
|
|||
| if decoded_k not in klass_properties: | |||
There was a problem hiding this comment.
possible optimiztion:
why not build up a lookup table, similar to klass_properties?
something that known these XML-serialization field names, and mapps them to the properties.
This might be better than looping through all these things and building a lookup in several looped iterations ....
the mapping would be built during register_xml_property_array_config() calls...
and could be applies here like so:
decoded_k = klass_properties_childnames_map.get(decoded_k, decoded_k)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89
Tests added to reproduce behaviour reported in #89 - now fail:
ValueError: stock_id is not a known Property for tests.model.Book