-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-Functional Buy Page #10
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mads256h
force-pushed
the
buy-page-non-functional
branch
4 times, most recently
from
September 14, 2024 09:10
772729d
to
48d282f
Compare
mads256h
force-pushed
the
buy-page-non-functional
branch
4 times, most recently
from
September 14, 2024 09:26
86a5dc1
to
4184fdb
Compare
Add a page where users can see available products and buy them using the quick-buy field. If the user just types in their user name they get presented with a clickable product menu where they can buy products. Otherwise they can use the multi-buy functionality to buy multiple products at once. The buying functionality is NOT implemented in this PR and as such usernames and products are not validated in the quick-buy query. Changes: - Add products table - Add quick-buy parser - Add streg cents - Add CI format and linter checks - Add scripts for starting and stopping a docker image with an empheral postgres database (gets cleared on stop) - Add script for adding sample data to the database - Serve files from the /static directory (should be done with a reverse proxy like nginx in production)
henneboy
reviewed
Sep 14, 2024
henneboy
reviewed
Sep 14, 2024
henneboy
reviewed
Sep 14, 2024
mads256h
force-pushed
the
buy-page-non-functional
branch
from
September 14, 2024 09:34
4184fdb
to
1702e71
Compare
henneboy
approved these changes
Sep 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Maybe next time make smaller PRs? :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a page where users can see available products and buy them using the
quick-buy field.
If the user just types in their user name they get presented with a
clickable product menu where they can buy products.
Otherwise they can use the multi-buy functionality to buy multiple
products at once.
The buying functionality is NOT implemented in this PR and as such
usernames and products are not validated in the quick-buy query.
Changes:
postgres database (gets cleared on stop)
proxy like nginx in production)