Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong method names in the DocBlocks #297

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Conversation

zepich
Copy link
Contributor

@zepich zepich commented Jan 22, 2024

I tried to use the ZipStream package today and copied the code from the example for a simple test.

But my IDE told me, that the method addFileFormPath does not exist (as visible here: https://github.com/maennchen/ZipStream-PHP/blob/main/src/ZipStream.php#L62).

After some time of searching and head-scratching, I saw the simple typo. I found some other wrong method names in the DocBlocks and adjusted them.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7608043128

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7566932757: 0.0%
Covered Lines: 519
Relevant Lines: 519

💛 - Coveralls

Copy link
Owner

@maennchen maennchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@maennchen maennchen merged commit 52db867 into maennchen:main Jan 22, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants