Skip to content

Commit

Permalink
Update composer.json
Browse files Browse the repository at this point in the history
  • Loading branch information
@magefan
magefan committed Jun 1, 2022
1 parent 3705dc8 commit b1e02da
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions composer.json
View file
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
{
"name": "magefan/module-blog-graph-ql",
"description": "GrapQl for Magento 2 Blog extension by Magefan",
"require": {
"magefan/module-blog" : ">=2.10.8"
},
"type": "magento2-module",
"version": "2.1.5",
"version": "2.1.6",
"autoload": {
"files": [ "registration.php" ],
"psr-4": {
Expand Down

3 comments on commit b1e02da

@pepijnblom
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was the require removed? This is not a standalone module is it?

@magefan
Copy link
Owner Author

@magefan magefan commented on b1e02da Jul 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pepijnblom , require has been removed as the magefan/module-blog-graph-ql was included to the magefan/module-blog out of the box magefan/module-blog@8ec92b1

@pepijnblom
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks for the fast explanation. That explains a lot. One of our frontenders had installed only magefan/module-blog-graph-ql which also pulled in the blog module. So now when a client requested an update for the blog module we were getting some weird results. Lesson learnt: never let frontend touch composer 🥲

Please sign in to comment.