Implement [FDN] collation #13164
Open
Implement [FDN] collation #13164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xenohedron
reviewed
Jan 3, 2025
| // 229 packs, 127 common, 78 uncommon, 19 rare/mythic, 5 borderless common/uncommon | ||
| private static final RarityConfiguration foilRuns(){ | ||
| int wildNum = RandomUtil.nextInt(229); | ||
| return ( wildNum < 224 ? wildNum < 205 ? wildNum < 127 ? |
There was a problem hiding this comment.
nested ternaries are hard to follow - can you please replace these with if/else ?
There was a problem hiding this comment.
Can do. (I used the ternaries because I found long if else structures confusing, but each to their own I guess.)
Sorry I didn't notice these comments earlier.
| booster.addAll(rareRuns( wildRare ? 2 : 1 ).getNext().makeRun()); | ||
|
|
||
| // 1.5% of Play Boosters features a Special Guests card displacing a common card. | ||
| if (RandomUtil.nextInt(200) <3) { |
There was a problem hiding this comment.
style - space around operators
| numCommon++; | ||
| }else if( wildNum < 9 ){ | ||
| wildUncommon = true; | ||
| }else{ |
There was a problem hiding this comment.
style - spaces before opening braces and after closing braces
| private final RarityConfiguration uncommonRuns3BC = new RarityConfiguration(BBC, BCC); | ||
| private final RarityConfiguration uncommonRuns4 = new RarityConfiguration(ABBC, ABCC); | ||
| private static final RarityConfiguration uncommonRuns(int runLength){ | ||
| return ( 4> runLength ? RandomUtil.nextInt(505) <454 ? |
There was a problem hiding this comment.
style: runlength < 4 is generally easier to follow than 4 > runlength. Variable before constant as a default (unless you have a strong obvious reason)
including nested ternaries -> if else if else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13160