Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Search Navigation not visible if default category has "Display Mode" other than "page" #39561

Open
3 of 5 tasks
m2-assistant bot opened this issue Jan 21, 2025 · 6 comments · May be fixed by #39555
Open
3 of 5 tasks

[Issue] Search Navigation not visible if default category has "Display Mode" other than "page" #39561

m2-assistant bot opened this issue Jan 21, 2025 · 6 comments · May be fixed by #39555
Labels
Area: Catalog Component: Search Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented Jan 21, 2025

This issue is automatically created based on existing pull request: #39555: Search Navigation not visible if default category has "Display Mode" other than "page"


Resolve search result navigation block visibility even if website default category has "Display Mode" with value other than "page"

Description (*)

In catalogsearch result page, the current category is the Default Category, see \Magento\Catalog\Model\Layer::getCurrentCategory()
In case the default category has Display mode value "Static block only" or "Static block and products", canShowBlock method condition is false and the navigation block is not visible.
Added a or condition to check also the routeName in canShowBlock method to avoid current behavior.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. Create a product attribute of type dropdown, add two options and configure storefront properties with
    • Use in Search: Yes
    • Use in Layered Navigation : Filterable with result
    • Use in Search Results Layered Navigation: Yes
  2. Add the attribute to Default attribute set
  3. Create 2 simple products (Default attribute set), and for each product set different value for the new attribute previously added.
  4. In Catalog > Category > Default Category set the Display mode "Static block only" or "Static block and products" and save
  5. Reindex and clear cache
  6. Layered navigation block is visible in search result page, previously was not.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
Copy link
Author

m2-assistant bot commented Jan 21, 2025

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Jan 21, 2025
@engcom-Bravo
Copy link
Contributor

Hi @lucafuser,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in Latest 2.4-develop instance and we are not able to reproduce the issue.Kindly refer the screenshots.

Image Image

Layered navigation block is visible.

Could you please let us know if we are missing anything and kindly elaborate the steps to reproduce and provide screenshots if possible to proceed further.

Thanks.

@engcom-Bravo engcom-Bravo added the Issue: needs update Additional information is require, waiting for response label Jan 22, 2025
@lucafuser
Copy link

lucafuser commented Jan 22, 2025

Hi @engcom-Bravo ,
thanks for the feedback.
To reproduce the issue you have to set the attribute "Display mode" on the default category es. "Default Category" with value "Static block only" or "Static block and products", not on the "Test" category.
Then go to homepage and do a product search, layered navigation block will not be visible in the search result page (sorry, I forgot to write it clearly in the steps).

Step to reproduce

  1. Create a product attribute of type dropdown, add two options and configure storefront properties with
    • Use in Search: Yes
    • Use in Layered Navigation : Filterable with result
    • Use in Search Results Layered Navigation: Yes
  2. Add the attribute to Default attribute set
  3. Create 2 simple products (Default attribute set), and for each product set different value for the new attribute previously added.
  4. On the "Default Category" set the Display mode "Static block only" or "Static block and products" and save
  5. Reindex and clear cache
  6. Go to homepage and do a product search
  7. Layered navigation block is not visible in search result page

Please let me know, thank you

@magento-ct-gh-projects-svc magento-ct-gh-projects-svc added Issue: ready for confirmation and removed Issue: needs update Additional information is require, waiting for response labels Jan 23, 2025
@engcom-Bravo engcom-Bravo moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Jan 23, 2025
@engcom-Bravo engcom-Bravo added the Issue: needs update Additional information is require, waiting for response label Jan 23, 2025
@magento-ct-gh-projects-svc magento-ct-gh-projects-svc added Issue: needs update Additional information is require, waiting for response and removed Issue: ready for confirmation Issue: needs update Additional information is require, waiting for response labels Jan 23, 2025
@engcom-Bravo
Copy link
Contributor

Hi @lucafuser,

Thanks for your update.

We have tried to reproduce the issue in Latest 2.4-develop magento instance and we are able to reproduce the issue.Kindly refer the screenshots.

Image Image

Layered navigation block is not visible.

Hence Confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo removed the Issue: needs update Additional information is require, waiting for response label Jan 23, 2025
@magento-ct-gh-projects-svc magento-ct-gh-projects-svc moved this from Needs Update to Ready for Confirmation in Issue Confirmation and Triage Board Jan 23, 2025
@engcom-Bravo engcom-Bravo added Component: Search Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Area: Catalog and removed Issue: ready for confirmation labels Jan 23, 2025
@magento-ct-gh-projects-svc magento-ct-gh-projects-svc moved this to Pull Request In Progress in High Priority Backlog Jan 23, 2025
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-13787 is successfully created for this GitHub issue.

Copy link
Author

m2-assistant bot commented Jan 23, 2025

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Catalog Component: Search Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Status: Pull Request In Progress
4 participants