Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Navigation not visible if default category has "Display Mode" other than "page" #39555

Open
wants to merge 6 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

lucafuser
Copy link

@lucafuser lucafuser commented Jan 20, 2025

Resolve search result navigation block visibility even if website default category has "Display Mode" with value other than "page"

Description (*)

In catalogsearch result page, the current category is the Default Category, see \Magento\Catalog\Model\Layer::getCurrentCategory()
In case the default category has Display mode value "Static block only" or "Static block and products", canShowBlock method condition is false and the navigation block is not visible.
Added a or condition to check also the routeName in canShowBlock method to avoid current behavior.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. Create a product attribute of type dropdown, add two options and configure storefront properties with
    • Use in Search: Yes
    • Use in Layered Navigation : Filterable with result
    • Use in Search Results Layered Navigation: Yes
  2. Add the attribute to Default attribute set
  3. Create 2 simple products (Default attribute set), and for each product set different value for the new attribute previously added.
  4. In Catalog > Category > Default Category set the Display mode "Static block only" or "Static block and products" and save
  5. Reindex and clear cache
  6. Layered navigation block is visible in search result page, previously was not.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Search Navigation not visible if default category has "Display Mode" other than "page" #39561: Search Navigation not visible if default category has "Display Mode" other than "page"

…ault category has "Display Mode" with value other than "page"
Copy link

m2-assistant bot commented Jan 20, 2025

Hi @lucafuser. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@lucafuser
Copy link
Author

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento create issue

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jan 21, 2025
@lucafuser
Copy link
Author

@magento run all tests

@lucafuser
Copy link
Author

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: review
Projects
Status: Review in Progress
Development

Successfully merging this pull request may close these issues.

[Issue] Search Navigation not visible if default category has "Display Mode" other than "page"
3 participants