add unenv plugin, fix global esbuild options #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nitedani is attempting to deploy a commit to the magne4000's projects Team on Vercel. A member of the Team first needs to authorize it. |
nitedani
commented
Aug 14, 2024
Comment on lines
+35
to
+46
| function getOwnPackagePath() { | ||
| const require_ = createRequire(import.meta.url); | ||
| // vercel/dist/index.cjs | ||
| const resolved = require_.resolve('vite-plugin-vercel'); | ||
| return path.resolve( | ||
| resolved, | ||
| // vercel/dist | ||
| '..', | ||
| // vercel | ||
| '..', | ||
| ); | ||
| } |
There was a problem hiding this comment.
Will this work once released?
|
CI fails here: Rerun? |
|
This isn't it yet. Telefunc doesn't work with this, we need unenv v2, which only has nightly versions now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unenv plugin, this allows libraries like telefunc to be used on the edge.
brillout/telefunc#117
Moved default esbuild options inside build function to prevent leaking between builds.