-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support rendering tables #120
Conversation
* The feature adds support for adding tabular data of panels at the end of the report. Users can choose which panel data must be included in the report by query parameters. Signed-off-by: Mahendra Paipuri <mahendra.paipuri@gmail.com>
Hi, |
Hey @vkhemani Cheers for your time in testing it. I forgot to mention that you need to pass the IDs of panels that you would like to include the tabular data using query parameter It has been already merged into main so you can try nightly release. |
hi,
I tried the updated version. i am getting the following error:
**********
logger=plugin.mahendrapaipuri-dashboardreporter-app t=2024-10-08T11:32:27.5646438+05:30 level=error msg="error generating report" pluginID=mahendrapaipuri-dashboardreporter-app endpoint=callResource err="error rendering CSVs in parallel for dashboard LL_EM1: error rendering CSV: error getting CSV for panel $Gateway: error waiting for download CSV button: context deadline exceeded"
**********
I also found another problem when using variables in Grafana. The report prints only the first value of the variable. In both Grid and Simple mode. This was not happenning earlier. Earlier, when i chose multiple variable values, it would print all the panels with different values, adjacent to each other.
Best regards
Vikas
…________________________________
From: Mahendra Paipuri ***@***.***>
Sent: 04 October 2024 16:08
To: mahendrapaipuri/grafana-dashboard-reporter-app ***@***.***>
Cc: vk ***@***.***>; Mention ***@***.***>
Subject: Re: [mahendrapaipuri/grafana-dashboard-reporter-app] Support rendering tables (PR #120)
Hey @vkhemani<https://github.com/vkhemani> Cheers for your time in testing it.
I forgot to mention that you need to pass the IDs of panels that you would like to include the tabular data using query parameter includePanelDataID. Check the updated docs<https://github.com/mahendrapaipuri/grafana-dashboard-reporter-app/blob/main/src/README.md#overriding-global-report-settings>. You can request for the data of regular panels as well not just table panels. This gives full flexbility of controlling which data you would like to include in the report.
It has been already merged into main so you can try nightly<https://github.com/mahendrapaipuri/grafana-dashboard-reporter-app/releases/tag/nightly> release.
—
Reply to this email directly, view it on GitHub<#120 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AT5THSITZJ752SVFXCUSRYTZZZVYXAVCNFSM6AAAAABPAWVIEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJTGM4TMOBTGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
hi,
Could you get a chance to check this error.
Best regards
Vikas
…________________________________
From: Vikas Khemani ***@***.***>
Sent: 08 October 2024 11:49
To: mahendrapaipuri/grafana-dashboard-reporter-app ***@***.***>; mahendrapaipuri/grafana-dashboard-reporter-app ***@***.***>
Cc: Mention ***@***.***>
Subject: Re: [mahendrapaipuri/grafana-dashboard-reporter-app] Support rendering tables (PR #120)
hi,
I tried the updated version. i am getting the following error:
**********
logger=plugin.mahendrapaipuri-dashboardreporter-app t=2024-10-08T11:32:27.5646438+05:30 level=error msg="error generating report" pluginID=mahendrapaipuri-dashboardreporter-app endpoint=callResource err="error rendering CSVs in parallel for dashboard LL_EM1: error rendering CSV: error getting CSV for panel $Gateway: error waiting for download CSV button: context deadline exceeded"
**********
I also found another problem when using variables in Grafana. The report prints only the first value of the variable. In both Grid and Simple mode. This was not happenning earlier. Earlier, when i chose multiple variable values, it would print all the panels with different values, adjacent to each other.
Best regards
Vikas
________________________________
From: Mahendra Paipuri ***@***.***>
Sent: 04 October 2024 16:08
To: mahendrapaipuri/grafana-dashboard-reporter-app ***@***.***>
Cc: vk ***@***.***>; Mention ***@***.***>
Subject: Re: [mahendrapaipuri/grafana-dashboard-reporter-app] Support rendering tables (PR #120)
Hey @vkhemani<https://github.com/vkhemani> Cheers for your time in testing it.
I forgot to mention that you need to pass the IDs of panels that you would like to include the tabular data using query parameter includePanelDataID. Check the updated docs<https://github.com/mahendrapaipuri/grafana-dashboard-reporter-app/blob/main/src/README.md#overriding-global-report-settings>. You can request for the data of regular panels as well not just table panels. This gives full flexbility of controlling which data you would like to include in the report.
It has been already merged into main so you can try nightly<https://github.com/mahendrapaipuri/grafana-dashboard-reporter-app/releases/tag/nightly> release.
—
Reply to this email directly, view it on GitHub<#120 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AT5THSITZJ752SVFXCUSRYTZZZVYXAVCNFSM6AAAAABPAWVIEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJTGM4TMOBTGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Hey @vkhemani Sorry I missed your comment. I moved it into new issue for better visibility. |
Closes #103