Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update all backend dependencies #50

Merged
merged 7 commits into from
Jul 8, 2024
Merged

deps: Update all backend dependencies #50

merged 7 commits into from
Jul 8, 2024

Conversation

jkroepke
Copy link
Contributor

@jkroepke jkroepke commented Jul 5, 2024

Before looking into #41, I would like to start with the lastest dependencies.

Copy link
Owner

@mahendrapaipuri mahendrapaipuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thanks a ton for all the work you made to put up those PRs. I will look into them as soon as I can. They all look great at the first glance. I have some suggestions so that we can discuss them on each PR.

Regarding the curren PR, I have very few minor comments. I think we need to update Validate plugin step as well as it uses the 1.21.x Go as of now.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@mahendrapaipuri
Copy link
Owner

Thanks for the changes @jkroepke

Regarding the curren PR, I have very few minor comments. I think we need to update Validate plugin step as well as it uses the 1.21.x Go as of now.

We are still missing this one. Could you please update it?

Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
Copy link
Owner

@mahendrapaipuri mahendrapaipuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the changes. LGTM!!

@jkroepke
Copy link
Contributor Author

jkroepke commented Jul 8, 2024

Now, the plugin validator breaks...

But it works with the old version.

https://github.com/mahendrapaipuri/grafana-dashboard-reporter-app/actions/runs/9838095126/job/27159448174?pr=50#step:19:140

Can be put the update of the plugin validator to a separat PR?

jkroepke and others added 2 commits July 8, 2024 15:13
Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
@mahendrapaipuri mahendrapaipuri merged commit 4ef76d8 into mahendrapaipuri:main Jul 8, 2024
2 checks passed
@jkroepke jkroepke deleted the update-deps branch July 8, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants