Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow custom templates #54

Closed
wants to merge 2 commits into from
Closed

feat: allow custom templates #54

wants to merge 2 commits into from

Conversation

jkroepke
Copy link
Contributor

@jkroepke jkroepke commented Jul 5, 2024

Fixed #19

@mahendrapaipuri mahendrapaipuri added the enhancement New feature or request label Jul 8, 2024
@PAPAMICA
Copy link

Good work !

I need this feature, can you merge please?

Have a nice day!

@mahendrapaipuri
Copy link
Owner

@PAPAMICA Cheers for your interest. If I may ask, what exactly you would like to override in the default template? This helps us to better design this feature.

We are in the process doing a huge refactor of the plugin so it will take a while before we can merge this. I have just relaunched CI and you should be able to get plugin artifacts after the CI run to use for your deployment if you need it right away.

@vlzobov
Copy link

vlzobov commented Aug 2, 2024

@mahendrapaipuri We're also interested in this feature. Team wants to use plugin, but wants report with customized styles and format.

As example one of the requirements: each row with it's panels should be on separate report page. (I'm not sure that is even possible, but that's what team want.)

As you mentioned a huge refactor, so when we can expect to have next release?

@jkroepke
Copy link
Contributor Author

jkroepke commented Aug 2, 2024

huge refactor

#52 - At least the refactoring is already in review.

@mahendrapaipuri
Copy link
Owner

As example one of the requirements: each row with it's panels should be on separate report page. (I'm not sure that is even possible, but that's what team want.)

This sort of fine grained control can be hard to achieve. As of now, I dont see a lot of value in allowing the custom template for the "body" of the report. The core plugin will fetch all the dashboard panels and estimate the coordinates of each panel in the report according to chosen config.

We can easily allow the users to customize the header and footer of the report but the body, I dont see a easy way. @jkroepke Do you have any ideas?

Regarding #52, I will look into it this weekend. Cheers!!

@jkroepke
Copy link
Contributor Author

jkroepke commented Aug 3, 2024

Do you have any ideas?

tbh. This PR is my idea. Expose the go templates as "expert only" feature and make them configurable. Maybe we do not have use cases for it but users may have use-cases which is valid. For example custom CSS/JS, special borders what ever.

There is no reason of not offering features.

jkroepke and others added 2 commits August 10, 2024 15:22
Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke jkroepke closed this Aug 14, 2024
@jkroepke jkroepke deleted the custom-template branch August 14, 2024 14:54
@vlzobov
Copy link

vlzobov commented Aug 19, 2024

Are custom templates already allowed in 1.5.0 release? If not, are you planning to include it next release?

@mahendrapaipuri
Copy link
Owner

Hey @vlzobov no not yet. I am waiting to merge a security related PR before working on template customization. I am waitin for upstream Grafana to make few changes for the PR to work.

@mahendrapaipuri
Copy link
Owner

Hello @vlzobov Please check the main branch which supports custom templates now. I will make a release next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modifying the output of generated report
4 participants