-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Tool changer buttons in extruder control panel #1561
feat: Tool changer buttons in extruder control panel #1561
Conversation
- Added a button for Tool Droppoff if there exists a macro named "TOOL_DROPOFF". - Added a button for Tool Lock if there exists a macro named "TOOL_LOCK". - Added a button for Tool Unlock if there exists a macro named "TOOL_UNLOCK". - Swedish translation for Extruder Control Panel
…thub.com/TypQxQ/mainsail into ToolChangerButtonsInExtruderControlPanel
Language file analysis report:
|
Language file analysis report:
|
Thx for your PR! Are these macro names a "standard"? |
This are the commands I use in KTCC and that reflects the functionality. Same macros names are also used in JubileeKlipper. I can't find different names used in Klipper for them. `TOOL_DROPOFF The |
Are there any current efforts to merge this code into Klipper? |
Fix the UI of the buttons and changed from looking only for macros to looking for macros or commands.
Language file analysis report:
|
Language file analysis report:
|
I don't think, that the word Tool- is necessary here. Is there also a state behind these buttons? That you can highlight the current state? |
I do have a way to know if tool is unlocked for KTCC because when unlocked: But that is only valid for KTCC. |
you could make the lock/unlock buttons as one bistate button with a state icon in it |
It's really hard to see if that lock is open or closed. I believe it is much better having text buttons and always having the option to unlock, In essence that is how most locks initialize so it doubles as a reset, init of the lock. As a sidenote I have the same pictogram in my electric car to lock or unlock the charger cable. It's a pain to see if it's locked or unlocked so by that experience I would not recommend it. Not without a better pictogram. |
colors |
Language file analysis report:
|
Language file analysis report:
|
What is the reason for this? Usually, we only merge default klipper functions. Would it be possible to have a tool-changer printer with klipper without this "plugin"? |
This would work with any toolchanger using those commands. For example the klipper macros from Xon would work with this just as well as with the KTCC plugin. Had I been able to make plugins for Mainsail, I would but I am submitting pull requests as we discussed on Discord. And I was planing to add more functionality specific to KTCC later. |
@TypQxQ but what is stopping you from merging this "plugin" into klipper now? Do you know how to create Vue "plugins" for a precompiled app? |
@meteyou I have no idea 🤷 how to make a "plugin" for Vue. Because it is all precompiled, I see that it lacks flexibility. This is regrettable. I was confused because I've never worked with precompiled web projects and although I see the benefits of it being faster on a small computer like the Pi, it's verry constrictive. Reason of not merging the KTCC plugin to Klipper mainstream is because it changes some of the core functionality in Klipper. Klipper revolves around the Extruder. You can't not have an extruder active. In KTCC every tool can have or not have an extruder or partcooling fan. An extruder can be shared between multiple tools or no extruder being used at all. Temperature is in Klipper one temperature for every extruder while in KTCC one Tool has Active temperature, Standby temperature and HeaterState (Active, Standby and Off). Switching tools needs to switch Active to Standby on previous tool and to Active on Next Tool. Also, Standby temperature has configurable timeout. For example, if a tool is used only in the beginning of print it is prudent to have it shut down to off after 10 minutes in Standby than having it at Standby temperature for the rest of the print. Partcooling fan is carried over when possible and it's possible to control the fan of an unused tool. Log and Statistics like for HappyHare, per print and persisitent for tool unlocks, locks, and individual tool mounts, unmounts. |
Language file analysis report:
|
It sounds like you have a lot more experience than me in web programming 😅. In my experience, Vue unfortunately doesn't offer any real possibility of modularly loading something that hasn't been compiled with the main app.
I have no influence on what will be merged in Klipper, but to me it all sounds like a good addition/further development of Klipper. Have you already had a conversation about this with Kevin? |
I am closing this PR because no response. Please create a new (up-to-date) PR if you want to continue working on this feature. |
Description
Not sure of the aesthetics as I have never before worked with Vue.
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
[optional] Are there any post-deployment tasks we need to perform?