feat: removes authconfig creation #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aslakknutsen not sure how many more changes you need for #64, but the current code is obsolete and will conflict with the new logic opendatahub-io/opendatahub-operator@7924666 |
- dashboard related traffic is now protected by using [single AuthConfig](opendatahub-io/opendatahub-operator@7924666) in the AppNamespace - removed logic. tests and assets related to AuthConfig creation
bartoszmajsak
force-pushed
the
auth_config_removal
branch
from
e308147 to
29547c0
Compare
|
Yeah, so #64 reuses the logic that you're removing for a different purpose, but i'll deal with that. |
aslakknutsen
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AuthConfigin the AppNamespaceAuthConfigcreationFixes #83