-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potion class, and how it is encoded #86
Open
zacharyLYH
wants to merge
13
commits into
makeopensource:v2.0
Choose a base branch
from
zacharyLYH:v2.0
base: v2.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
6e5dea6
Added game objects, potions and currency
zacharyLYH e4ba2d3
Added obj class, potions and money
zacharyLYH 60e3010
Merge branch 'v2.0' of github.com:zacharyLYH/Classic-RPG into v2.0
zacharyLYH 5821f1d
added title
zacharyLYH e997e95
Changed Node implementation
zacharyLYH 55a9156
Delete .DS_Store
zacharyLYH dd8b117
Delete LICENSE
zacharyLYH b165b9b
Merge branch 'makeopensource:v2.0' into v2.0
zacharyLYH ff1c193
Added Health and Speed class. Also added a showBag() feature to displ…
zacharyLYH f0c8f3a
gitignore
zacharyLYH c12cc59
rebase
zacharyLYH 3a7d484
Updated gitignore
zacharyLYH e02d36d
1) bug fixes 2)added extract_number function to extract the amount as…
zacharyLYH File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,11 @@ | ||
1 | starting | castle | You wake up in the prison cell of an abandoned castle. | ||
2 | node | examine skeleton | You examine the skeleton of a corpse. | ||
3 | node | open cell gate | The cell gate is unlocked. You push it open. | ||
3 | potion | pohealth | Pick up potion | ||
4 | node | left corridor | The corridor leads to an open door to the castle's courtyard. | ||
9 | location | courtyard | You enter the castle's courtyard. | ||
5 | node | right corridor | The corridor leads to a large flight of stairs to the dungeon. | ||
10 | location | dungeon | You enter the castle's dungeon. | ||
6 | node | scale stairs | A dragon swoops down from the sky, blocking your path. | ||
7 | fight | fight dragon | You vanquish the dragon. | ||
8 | run | run from dragon | You run from the dragon. | ||
5 | currency | 1000 | Collect money | ||
--- | ||
1 <-> 2 | ||
1 -> 3 | ||
3 -> 4 | ||
3 -> 5 | ||
4 -> 9 | ||
5 -> 10 | ||
9 -> 6 | ||
6 -> 7 | ||
6 -> 8 | ||
7 -> 4 | ||
8 -> 4 | ||
1 <-> 3 | ||
1 -> 2 | ||
2 -> 4 | ||
2 <-> 5 | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should steer away from instructions on modifying the code itself. Instead, we can comment above and within the functions we write so that devs can understand exactly what each function does!