MetaMorpho D3M

[hexonaut]

D3M into MetaMorpho Vault with a multisig operator.

[DaiFoundation-DevOps]

All committers have signed the CLA.

[hexonaut]

Two minor issues. Looks good otherwise.

[hexonaut]

Ok both contracts LGTM. Will do test review shortly.

[sunbreak1211]

@hexonaut let's add the date to the audit file name.

[SidestreamColdMelon]

While writing integration test for this module in the 2024-03-26 spell, I noticed that for the previous D3Ms we've tested disabling the plan with via MOM and effectively bringing art and ink to ~0, see (SPARK, AAVEV2, COMPV2). Doing the same with this module currently doesn't seem to work. Am I missing something obvious?

[hexonaut]

While writing integration test for this module in the 2024-03-26 spell, I noticed that for the previous D3Ms we've tested disabling the plan with via MOM and effectively bringing art and ink to ~0, see (SPARK, AAVEV2, COMPV2). Doing the same with this module currently doesn't seem to work. Am I missing something obvious?

Sorry forgot to mention about this. I added a response to fix: makerdao/spells-mainnet#402 (review)

[SidestreamColdMelon]

FYI: D3MInit.sol imports DssInstance from the dss-test and requires it to be passed to the init scripts. This implies importing MCD library in the spell, which in turn imports GodMode and vm contracts, which eventually leads to them being deployed with the spell. This at least significantly increases deployment transaction cost. Note that this pattern is present across past spells as well, see spark D3M being deployed in 2023-04-28. (But as current spell is already deployed, it should be irrelevant for this PR, therefore explicitly leaving it as FYI)

[sunbreak1211]

@hexonaut two comments:

• very minor: can we change the audit file name to: 2024_03_Spearbit-report-maker-d3m-implementation-for-morpho-review. It seems easier for who is looking at the list to identify the file.
• who and when will be taking care to remove the dependencies so we can finish the PR and merge it?

[hexonaut]

@hexonaut two comments:

• very minor: can we change the audit file name to: 2024_03_Spearbit-report-maker-d3m-implementation-for-morpho-review. It seems easier for who is looking at the list to identify the file.
• who and when will be taking care to remove the dependencies so we can finish the PR and merge it?

Renamed audit file.

@MathisGD are you able to copy in any dependencies to remove the solmate and metamorpho libraries?

[hexonaut]

Morpho dep has been removed/inlined. This is good to merge now imo.

[sunbreak1211]

LGTM

[hexonaut]

Going to merge this. Additional cleanup can be done via separate PRs.