Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Colab links in notebooks. Remove old environment.yml file. #95

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

leehart
Copy link
Collaborator

@leehart leehart commented Nov 26, 2024

Re: issue #94

Also issue #83

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@leehart
Copy link
Collaborator Author

leehart commented Nov 26, 2024

We will need to check to see if this actually deploys OK, after it gets merged into master and triggers the GitHub Actions.

jupyter-book/jupyter-book#1428 suggests that there will still be a rocket icon, but it will display an empty dropdown, which we don't' have a solution for yet.

@ahernank
Copy link
Collaborator

Fyi, code from training repo:

launch_buttons:
  notebook_interface: "jupyterlab"
  colab_url: "https://colab.research.google.com"
  binderhub_url: ""  # disable binderhub, support colab only

@leehart leehart marked this pull request as ready for review November 26, 2024 17:40
Copy link
Collaborator

@ahernank ahernank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leehart! Seems kind of fair that if we want to fully clean-up the "interactiveness", i.e. the rocket, to have to go full markdown.

@leehart leehart merged commit a59c0b0 into master Nov 26, 2024
1 check passed
@leehart leehart deleted the GH94_remove_Colab_links branch November 26, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants