Add notifications for previous top bidders in open auction (Joystream…

…#319) * add notifications for previous top bidders in open auction * bump package version and update CHANGELOG
malchililj · Mar 16, 2024 · f9cc055 · f9cc055
1 parent 8697a54
commit f9cc055
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # 4.0.0
 
+## Misc
+
+- Enable both in App and email notifications for `previousTopBidder` in NFT Open Auction.
+
+# 4.0.0
+
 This is Creator Tokens (CRT) release. It introduces the CRT mappings, custom resolvers and mutations.
 
 # 3.7.0

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
  "name": "orion",
- "version": "4.0.0",
+ "version": "4.0.1",
  "engines": {
  "node": ">=16"
  },

diff --git a/src/mappings/content/utils.ts b/src/mappings/content/utils.ts
@@ -466,10 +466,12 @@ export async function createBid(
  auction.auctionType.isTypeOf === 'AuctionTypeEnglish'
  ) {
  newBid.previousTopBidId = previousTopBidId
- return { bid: newBid, auction, previousTopBid, auctionBids }
  }
 
- return { bid: newBid, auction, auctionBids }
+ // Although there is no notion of a "previousTopBid" in the OpenAuction type
+ // as all active bids are considered valid, but we still return it whether the
+ // auction type is "Open" or "English" for notification purposes.
+ return { bid: newBid, auction, previousTopBid, auctionBids }
 }
 
 export async function getChannelOwnerMemberByVideoId(