Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from ct/kwh to currency/kwh #128

Closed
wants to merge 13 commits into from
Closed

Conversation

suaveolent
Copy link

@suaveolent suaveolent commented Jun 3, 2024

This PR changes from the ct/kWh to €/£/mWh/kWh as preferred by Home Assistant (see #122).

@suaveolent
Copy link
Author

@mampfes Did you have time to look at the PR? Do you need me to change anything?

@mampfes
Copy link
Owner

mampfes commented Jun 28, 2024

Thanks for your contribution. Sorry, I'm really busy at the moment. I didn't had time to review the PR completely, but I have some comments upfront (not sure if you want / can address them):

  • I would call it price_per_kwh (instead of price_currency_per_xxx)
  • The sources should return (only) price_per_kwh -> remove price_eur_per_mwh and price_ct_per_kwh
  • As there are always mistakes between the price and the net-price sensor, I want to remove the price-sensor and keep the net price sensor (the one which includes surcharge and VAT), but rename it to price-sensor.
  • It would be nice if the integration detects after an update that the old surcharge/VAT uses a different unit of measure and automatically convert it.

RustyDust and others added 11 commits September 17, 2024 07:40
Signed-off-by: Stefan Rubner <stefan@whocares.de>
Signed-off-by: Stefan Rubner <stefan@whocares.de>
Signed-off-by: Stefan Rubner <stefan@whocares.de>
Signed-off-by: Stefan Rubner <stefan@whocares.de>
EPEX Spot recently changes the homepage, therefore, adaptions were
needed.
EPEX Spot blocks requests without a standard user agent.
@suaveolent
Copy link
Author

I will create a new PR with these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants