Code hygiene according to clippy recommendations.

clippy.toml

@@ -0,0 +1 @@
+allowed-duplicate-crates = ["syn"]

qty-macros/src/quantity_attr_helper.rs

@@ -430,8 +430,8 @@ fn codegen_qty_single_unit(
             fn iter() -> impl Iterator<Item = Self> {
                 Self::VARIANTS.iter().cloned()
             }
-            fn name(&self) -> String { #unit_name.to_string() }
-            fn symbol(&self) -> String { #unit_symbol.to_string() }
+            fn name(&self) -> String { #unit_name.to_owned() }
+            fn symbol(&self) -> String { #unit_symbol.to_owned() }
             fn si_prefix(&self) -> Option<SIPrefix> { None }
         }
         #[derive(Copy, Clone, Debug)]
@@ -533,7 +533,7 @@ fn codegen_fn_name(units: &Vec<UnitDef>) -> TokenStream {
         let unit_name = unit.name.clone();
         code = quote!(
             #code
-            Self::#unit_ident => #unit_name.to_string(),
+            Self::#unit_ident => #unit_name.to_owned(),
         )
     }
     quote!(
@@ -552,7 +552,7 @@ fn codegen_fn_symbol(units: &Vec<UnitDef>) -> TokenStream {
         let unit_symbol = unit.symbol.clone();
         code = quote!(
             #code
-            Self::#unit_ident => #unit_symbol.to_string(),
+            Self::#unit_ident => #unit_symbol.to_owned(),
         )
     }
     quote!(

src/converter.rs

@@ -24,6 +24,7 @@ pub trait Converter<Q: Quantity> {
 /// * to_unit: Q::UnitType,
 /// * factor: AmountT,
 /// * offset: AmountT
+///
 /// defining the conversion
 /// to_amount = from_amount * factor + offset
 #[derive(Debug)]

src/lib.rs

@@ -33,7 +33,7 @@
 #![warn(clippy::integer_division)]
 #![warn(clippy::manual_assert)]
 #![warn(clippy::match_same_arms)]
-// #![warn(clippy::mismatching_type_param_order)] TODO: enable when got stable
+#![warn(clippy::mismatching_type_param_order)]
 #![warn(clippy::missing_const_for_fn)]
 #![warn(clippy::missing_errors_doc)]
 #![warn(clippy::missing_panics_doc)]
@@ -58,10 +58,7 @@
 
 extern crate alloc;
 
-use alloc::{
-    format,
-    string::{String, ToString},
-};
+use alloc::{borrow::ToOwned, format, string::String};
 use core::{
     cmp::Ordering,
     fmt,
@@ -136,12 +133,7 @@ pub trait Unit:
     /// there is no such unit.
     #[must_use]
     fn from_symbol(symbol: &str) -> Option<Self> {
-        for unit in Self::iter() {
-            if unit.symbol() == symbol {
-                return Some(unit);
-            }
-        }
-        None
+        Self::iter().find(|&unit| unit.symbol() == symbol)
     }
 
     /// Returns the name of `self`.
@@ -178,12 +170,7 @@ pub trait LinearScaledUnit: Unit {
     /// if there is no such unit.
     #[must_use]
     fn from_scale(amnt: AmountT) -> Option<Self> {
-        for unit in Self::iter() {
-            if unit.scale() == amnt {
-                return Some(unit);
-            }
-        }
-        None
+        Self::iter().find(|&unit| unit.scale() == amnt)
     }
 
     /// Returns `true` if `self` is the reference unit of its unit type.
@@ -208,6 +195,7 @@ pub trait Quantity: Copy + Sized + Mul<AmountT> {
     type UnitType: Unit<QuantityType = Self>;
 
     /// Returns an iterator over the variants of `Self::UnitType`.
+    #[must_use]
     fn iter_units() -> impl Iterator<Item = Self::UnitType> {
         Self::UnitType::iter()
     }
@@ -216,12 +204,7 @@ pub trait Quantity: Copy + Sized + Mul<AmountT> {
     /// there is no such unit.
     #[must_use]
     fn unit_from_symbol(symbol: &str) -> Option<Self::UnitType> {
-        for unit in Self::iter_units() {
-            if unit.symbol() == symbol {
-                return Some(unit);
-            }
-        }
-        None
+        Self::iter_units().find(|&unit| unit.symbol() == symbol)
     }
 
     /// Returns a new instance of the type implementing `Quantity`.
@@ -341,12 +324,7 @@ where
     /// there is no such unit.
     #[must_use]
     fn unit_from_scale(amnt: AmountT) -> Option<Self::UnitType> {
-        for unit in Self::iter_units() {
-            if unit.scale() == amnt {
-                return Some(unit);
-            }
-        }
-        None
+        Self::iter_units().find(|&unit| unit.scale() == amnt)
     }
 
     /// Returns `factor` so that `factor` * `unit` == `self`.
@@ -446,10 +424,10 @@ impl Unit for One {
         Self::VARIANTS.iter().cloned()
     }
     fn name(&self) -> String {
-        "One".to_string()
+        "One".to_owned()
     }
     fn symbol(&self) -> String {
-        "".to_string()
+        "".to_owned()
     }
     fn si_prefix(&self) -> Option<SIPrefix> {
         None

src/prelude.rs

@@ -10,7 +10,7 @@
 //! This module reexports all macros and types needed to define a quantity.
 
 #[doc(hidden)]
-pub use alloc::string::{String, ToString};
+pub use alloc::{borrow::ToOwned, string::String};
 #[doc(hidden)]
 pub use core::cmp::Ordering;
 #[doc(hidden)]