Hotfix/include graphql in 2.1.0 schema #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pr, we perform a couple of things:
Attention
We also have found that tests were not running, as the initial path from where collections were loaded was being prefixed with "/", which means an absolute test folder (e.e /tests). This was obviously wrong, and to further prove that we inserted random characters in the json collections. Tests were passing, which means that the collections were not even loaded.
As we removed the "/" (slash) from the initial collections path, thus using now a path relative to where cargo test is run, we got the invalid serialization errors, which means the collections were now being loaded as expected.
We performed these tests in a Linux environment, using bash. As far as we are aware, all other shells in Linux and Mac OS will consider paths prefixed with a "/" as absolute, so this needed to be fixed. Always refer to relative paths either beginning with the relative folder name directly (no slash) or using "./" to be explicit on the fact that . (a "magic" directory name which means the current directory) should be considered as the starting point to calculate sub folders.
With that fix, tests were run and failed. I didn't fix them because, frankly, I still don't understand what they are supposed to do (not saying they make no sense, only saying I could not understand what they are supposed to test). I ask you please to run cargo test and fix these tests. For reference, even the aster branch (without this pr applied) also failed, so the changes introduced here are not responsible for that. As I said, tests were passing because the collections were not even loaded. I would code these tests to fail if no ccjson files are found, to further prevent this from happening again.