Update display_interface.py #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
self.disp.clear() need to be removed since clear function does not work add import PIL.Image for bug fix
CullenSUN
reviewed
Oct 25, 2024
| @@ -18,6 +18,7 @@ | |||
| # @Author : Yunlong Feng | |||
|
|
|||
| import PIL | |||
| import PIL.Image | |||
There was a problem hiding this comment.
from syntax, I don't understand why we need to import this.
since we import PIL already in line 20, it shall be ok as we do in line 42
image = PIL.Image.fromarray(cv2.cvtColor(cv_img, cv2.COLOR_BGR2RGB))
| @@ -35,7 +36,6 @@ def __init__(self): | |||
| self.get_logger().info("Creating LCD hardware interface") | |||
| self.disp = ST7789() | |||
| self.disp.begin() | |||
| self.disp.clear() | |||
There was a problem hiding this comment.
do you have a reference url saying it's not working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self.disp.clear() need to be removed since clear function does not work
add import PIL.Image for bug fix