Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Cartographer and Navigation2 in Humble #38

Merged
merged 11 commits into from
Feb 19, 2023

Conversation

Ericsii
Copy link
Contributor

@Ericsii Ericsii commented Jan 5, 2023

Proposed change(s)

Add cartographer & navigation2 support.

Useful links (GitHub issues, forum threads, etc.)

#39

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code refactor (non-breaking change which refactor the code)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update only
  • Other (please describe)

Testing and Verification

Please describe the tests that you ran to verify your changes. Please also provide instructions and ROS packages as appropriate so we can reproduce the test environment.

ros2 launch mini_pupper_gazebo gazebo.launch.py
ros2 launch mini_pupper_navigation bringup.launch.py use_sim_time:=true

Test Configuration

Mini Pupper Version
Simulator

Raspberry Pi OS + ROS version
No

PC OS + ROS version
Ubuntu 22.04, ROS 2 Humble

Checklist

  • I have checked to ensure there aren't other open Pull Requests for the same change.

Other comments

@Tiryoh Tiryoh added this to the ROS 2 Humble Patch Release 1 milestone Jan 7, 2023
@Tiryoh Tiryoh changed the title Support cartographer in Humble Support cartographer and navigation2 in Humble Feb 19, 2023
Copy link
Contributor

@Tiryoh Tiryoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I was finally able to confirm that it works.

ScreenRecord-2023-02-20_01.10.18.mp4

The map will be updated during navigation, but this will be handled separately.

image

@Tiryoh
Copy link
Contributor

Tiryoh commented Feb 19, 2023

This is not directly related to this Pull Request, but is noted for the record.
During testing, I repeatedly encountered errors starting Gazebo and Navigation nodes.

Gazebo error 1

image

Gazebo error 2

image

Navigation node launch error

image

@Tiryoh Tiryoh added enhancement New feature or request and removed in progress Work in Progress labels Feb 19, 2023
@Tiryoh Tiryoh changed the title Support cartographer and navigation2 in Humble Support Cartographer and Navigation2 in Humble Feb 19, 2023
@Tiryoh Tiryoh merged commit cc4b2d2 into mangdangroboticsclub:ros2 Feb 19, 2023
@Ericsii Ericsii deleted the feature/navigation branch March 30, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants