Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix launch file to avoid launching packages for real robots during simulation #51

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

Tiryoh
Copy link
Contributor

@Tiryoh Tiryoh commented Mar 4, 2023

Proposed change(s)

Update hardware_connected to joint_hardware_connected to avoid launching packages for real robots during simulation

Useful links (GitHub issues, forum threads, etc.)

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code refactor (non-breaking change which refactor the code)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update only
  • Other (please describe)

Testing and Verification

Please describe the tests that you ran to verify your changes. Please also provide instructions and ROS packages as appropriate so we can reproduce the test environment.

  1. checkout https://github.com/Tiryoh/mangdang_mini_pupper_ros/tree/patch-19 and run colcon build --symlink-install
  2. run ros2 launch mini_pupper_gazebo gazebo.launch.py
  3. run ros2 node list and see no lidar or servo specific nodes are launched

Test Configuration

Mini Pupper Version
Simulator

PC OS + ROS version
Ubuntu 22.04, ROS 2 Humble

Checklist

  • I have read the CONTRIBUTING guidelines.
  • I have checked to ensure there aren't other open Pull Requests for the same change.

Other comments

@Tiryoh Tiryoh added this to the ROS 2 Humble Patch Release 1 milestone Mar 4, 2023
@Tiryoh Tiryoh merged commit b0a6bf9 into mangdangroboticsclub:ros2 Mar 6, 2023
@Tiryoh Tiryoh changed the title Update launch file to avoid launching packages for real robots during simulation Fix launch file to avoid launching packages for real robots during simulation Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant