Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lidar link inconsistent issue #66

Merged

Conversation

CullenSUN
Copy link
Contributor

@CullenSUN CullenSUN commented Mar 25, 2023

Proposed change(s)

Lidar and lidar_link was messed up. This fix is to make it correct.

Useful links (GitHub issues, forum threads, etc.)

Provide any relevant links here.

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code refactor (non-breaking change which refactor the code)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update only
  • Other (please describe)

Testing and Verification

Please describe the tests that you ran to verify your changes. Please also provide instructions and ROS packages as appropriate so we can reproduce the test environment.

  1. ros2 launch mini_pupper_config gazebo.launch.py
  2. ros2 launch mini_pupper_config navigate.launch.py rviz:=true use_sim_time:=true

Test Configuration

Mini Pupper Version
[e.g. Simulator, Mini Pupper, Mini Pupper 2, Mini Pupper 2 Pro]
Simulator
Raspberry Pi OS + ROS version
[e.g. Ubuntu 22.04, ROS 2 Humble]

PC OS + ROS version
[e.g. Ubuntu 22.04, ROS 2 Humble]
Ubuntu 22.04, ROS 2 Humble

Checklist

  • I have read the CONTRIBUTING guidelines.
  • I have checked to ensure there aren't other open Pull Requests for the same change.

Other comments

<material>Gazebo/FlatBlack</material>
<sensor type="ray" name="lidar">
<always_on>true</always_on>
<visualize>false</visualize>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was deleted because it's duplicated with line 1751

@Tiryoh Tiryoh self-requested a review March 25, 2023 18:36
@Tiryoh
Copy link
Contributor

Tiryoh commented Mar 26, 2023

@Tiryoh Tiryoh merged commit ee1ee7c into mangdangroboticsclub:ros2 Mar 26, 2023
@CullenSUN CullenSUN deleted the feature/fix-lidar-link-issue branch April 28, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants