Feature/add music to dance #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CullenSUN
commented
Oct 29, 2023
CullenSUN
commented
- Create a new node with music service, which accepts comment to start or stop the music.
- Update dance node, send start music for the first command, send stop music after last command.
mangdangroboticsclub
merged commit 11d36ce
into
mangdangroboticsclub:ros2-dev-danceScript
3 checks passed
mangdangroboticsclub
pushed a commit
that referenced
this pull request
Mar 29, 2024
* Update dance script function * Feature/add music to dance (#81) * add music package * update steps in read me file * fix ci errors * fix flake8 errors * Fix flake8 * remove ending white space * continue fix ci errors * fix flake errors * improve code thread safety * improve performance of dance node script * fix tuple syntax error * fix flake * fix flake8 * simplify music server with playsound package and support mp3 files (#82) * simplify music server with playsound package and support mp3 files * put music playing in background thread * use pygame to play sound * use thread pool instead of thread * remove threading handling because that's outofbox from pygame * use playsound again to try * Try Pydub * add time to play sound feature * Add logs * Fix Duration bug * Polish up PR for review * add stop function * Put playing on background * Improve music player * Split Music service into two * Add read me doc for music package * update main read me * Fix typo * Fix deprecated syntax (#84) * Clean up documents (#85) * add: mini pupper 2 urdf working in rviz * remove vs code files * rename to mini-pupper-2-description * make bring up launch file able to launch both mini-pupper and mini-pupper 2 * pick up changes from Peter * fix minor syntax and read me * fix flake errors * fix small syntax issue * fix long loading issue of xacro file * tidy up mesh files * further fix file path * simplify launch file * Recentered leg links and applied symmetry * update joint movement range according to the actual robot * Applied symmetry to all links' center of mass and inertia * use mp 1 legs * Fix ros control parameters * Add config for init z position * Fix colors * restore mp1 files * remove unused urdf files * Add lidar link This reverts commit 6407687. mini_pupper_2_description/urdf/mini_pupper_description.urdf.xacro --------- Co-authored-by: Afreez <fae@mangdang.net> Co-authored-by: Peter Nimac <nimac.peter@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.