Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap home and browse #2682

Merged
merged 9 commits into from
Jun 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions web/components/feed/live-generated-feed.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { useAPIGetter } from 'web/hooks/use-api-getter'
import { FeedContractCard } from 'web/components/contract/feed-contract-card'
import { VisibilityObserver } from 'web/components/widgets/visibility-observer'
import { usePersistentInMemoryState } from 'web/hooks/use-persistent-in-memory-state'
import { useEffect, useState } from 'react'
import { Fragment, useEffect, useState } from 'react'
import { APIResponse } from 'common/api/schema'
import { uniqBy } from 'lodash'
import { ScoredFeedRepost } from 'web/components/feed/scored-feed-repost-item'
Expand Down Expand Up @@ -98,10 +98,9 @@ export function LiveGeneratedFeed(props: { userId: string; reload: boolean }) {
const adIndex = i / AD_PERIOD - 1
const ad = ads[adIndex]
return (
<>
<Fragment key={contract.id + comment?.id}>
{i % AD_PERIOD === 0 && i !== 0 && ad && (
<FeedCard
key={ad.contract.id + comment?.id}
contract={ad.contract}
repost={undefined}
comment={undefined}
Expand All @@ -112,15 +111,14 @@ export function LiveGeneratedFeed(props: { userId: string; reload: boolean }) {
/>
)}
<FeedCard
key={contract.id + comment?.id}
contract={contract}
repost={repost}
comment={comment}
bet={bet}
user={user}
reason={idsToReason[contract.id]}
/>
</>
</Fragment>
)
})}
<div className="relative">
Expand Down
8 changes: 4 additions & 4 deletions web/components/nav/bottom-nav-bar.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { Dialog, Transition } from '@headlessui/react'
import {
GlobeAltIcon,
HomeIcon,
NewspaperIcon,
QuestionMarkCircleIcon,
Expand All @@ -10,7 +11,6 @@ import { MenuAlt3Icon, XIcon } from '@heroicons/react/solid'
import clsx from 'clsx'
import Link from 'next/link'
import { Fragment, useState } from 'react'
import { BiSearchAlt2 } from 'react-icons/bi'
import { User } from 'common/user'
import { usePathname } from 'next/navigation'
import { GiCapitol } from 'react-icons/gi'
Expand Down Expand Up @@ -42,9 +42,9 @@ function getNavigation(user: User) {
icon: HomeIcon,
},
{
name: 'Browse',
href: '/browse?fy=1&f=open',
icon: BiSearchAlt2,
name: 'Explore',
href: '/explore',
icon: GlobeAltIcon,
},
// {
// name: 'Politics',
Expand Down
10 changes: 5 additions & 5 deletions web/components/nav/sidebar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ import {
StarIcon,
QuestionMarkCircleIcon,
NewspaperIcon,
SearchIcon,
LightningBoltIcon,
LoginIcon,
TemplateIcon,
GlobeAltIcon,
} from '@heroicons/react/outline'
import TrophyIcon from 'web/lib/icons/trophy-icon.svg'
import { GiCapitol } from 'react-icons/gi'
Expand Down Expand Up @@ -138,9 +138,9 @@ const getDesktopNav = (
return buildArray(
{ name: 'Home', href: '/home', icon: HomeIcon },
{
name: 'Browse',
href: '/browse?fy=1&f=open',
icon: SearchIcon,
name: 'Explore',
href: '/explore',
icon: GlobeAltIcon,
},
{
name: 'Notifications',
Expand Down Expand Up @@ -178,7 +178,7 @@ const getDesktopNav = (
)

return buildArray(
{ name: 'Browse', href: '/browse', icon: SearchIcon },
{ name: 'Home', href: '/home', icon: HomeIcon },
{
name: 'US Politics',
href: '/politics',
Expand Down
68 changes: 37 additions & 31 deletions web/components/portfolio/portfolio-value-section.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -219,23 +219,27 @@ export const PortfolioValueSection = memo(
setPortfolioFocus={onSetPortfolioFocus}
portfolioHoveredGraph={portfolioHoveredGraph}
setPortfolioHoveredGraph={setPortfolioHoveredGraph}
graphElement={(width, height) => (
<PortfolioGraph
mode={graphMode}
duration={currentTimePeriod}
portfolioHistory={portfolioHistory}
width={width}
height={height}
zoomParams={zoomParams}
hideXAxis={currentTimePeriod !== 'allTime' && isMobile}
firstProfit={firstProfit}
updateGraphValues={updateGraphValues}
portfolioFocus={portfolioFocus}
setPortfolioFocus={onSetPortfolioFocus}
portfolioHoveredGraph={portfolioHoveredGraph}
setPortfolioHoveredGraph={setPortfolioHoveredGraph}
/>
)}
graphElement={
portfolioHistory.length < 2
? undefined
: (width, height) => (
<PortfolioGraph
mode={graphMode}
duration={currentTimePeriod}
portfolioHistory={portfolioHistory}
width={width}
height={height}
zoomParams={zoomParams}
hideXAxis={currentTimePeriod !== 'allTime' && isMobile}
firstProfit={firstProfit}
updateGraphValues={updateGraphValues}
portfolioFocus={portfolioFocus}
setPortfolioFocus={onSetPortfolioFocus}
portfolioHoveredGraph={portfolioHoveredGraph}
setPortfolioHoveredGraph={setPortfolioHoveredGraph}
/>
)
}
onlyShowProfit={onlyShowProfit}
placement={isMobile && !onlyShowProfit ? 'bottom' : undefined}
className={clsx(graphContainerClassName, !isMobile && 'mb-4')}
Expand All @@ -254,7 +258,7 @@ function PortfolioValueSkeleton(props: {
graphMode: GraphMode
currentTimePeriod: Period
setCurrentTimePeriod: (timePeriod: Period) => void
graphElement: (width: number, height: number) => ReactNode
graphElement: ((width: number, height: number) => ReactNode) | undefined
hideSwitcher?: boolean
className?: string
switcherColor?: ColorType
Expand Down Expand Up @@ -472,19 +476,21 @@ function PortfolioValueSkeleton(props: {
</>
)}
</div>
<SizedContainer
className={clsx(
className,
'mt-2',
size == 'sm' ? 'h-[80px] sm:h-[100px]' : 'h-[125px] sm:h-[200px]'
)}
style={{
paddingRight: Y_AXIS_MARGIN,
}}
>
{graphElement}
</SizedContainer>
{!hideSwitcher && (
{graphElement && (
<SizedContainer
className={clsx(
className,
'mt-2',
size == 'sm' ? 'h-[80px] sm:h-[100px]' : 'h-[125px] sm:h-[200px]'
)}
style={{
paddingRight: Y_AXIS_MARGIN,
}}
>
{graphElement}
</SizedContainer>
)}
{!hideSwitcher && graphElement && (
<TimeRangePicker
currentTimePeriod={currentTimePeriod}
setCurrentTimePeriod={setCurrentTimePeriod}
Expand Down
4 changes: 2 additions & 2 deletions web/components/search/user-results.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import Link from 'next/link'
import { useState } from 'react'
import { useIsMobile } from 'web/hooks/use-is-mobile'

export const MAX_SHOWN = 15
export const MAX_SHOWN_MOBILE = 8
export const MAX_SHOWN = 18
export const MAX_SHOWN_MOBILE = 9

export function UserResults(props: { userResults: FullUser[] }) {
const { userResults } = props
Expand Down
Loading
Loading