Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write to answer native columns and remove trigger #2755

Closed
wants to merge 4 commits into from
Closed

Conversation

sipec
Copy link
Member

@sipec sipec commented Jul 31, 2024

to migrate, these commits should be deployed/run serially. (1st write native column and data, 2nd drop the populate trigger, 3rd stop writing to data).

we don't actually add house liquidity to answers ever so i was a bit lazy with that code.

Copy link

vercel bot commented Jul 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
dev ⬜️ Ignored (Inspect) Visit Preview Aug 1, 2024 0:16am
docs ⬜️ Ignored (Inspect) Visit Preview Aug 1, 2024 0:16am
prod ⬜️ Ignored (Inspect) Visit Preview Aug 1, 2024 0:16am

@sipec sipec requested a review from jahooma July 31, 2024 20:52
Copy link
Collaborator

@jahooma jahooma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Sinclair!

@sipec sipec force-pushed the answer-writes branch 2 times, most recently from 19bf5fa to afb980a Compare July 31, 2024 22:46
@sipec
Copy link
Member Author

sipec commented Aug 1, 2024

rebase merged

@sipec sipec closed this Aug 1, 2024
@sipec sipec deleted the answer-writes branch August 5, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants