conditional orderbook tab and button #2888
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
Could you post a screeny? |
| size="lg" | ||
| onClick={() => { | ||
| setShowOrderBook((prev) => !prev) | ||
| if (!showOrderBook) { |
There was a problem hiding this comment.
what's this clause for?
| } | ||
| ) | ||
|
|
||
| const filteredTabs = tabs.filter(Boolean) |
There was a problem hiding this comment.
I don't think you need this filter
| const unfilledBets = | ||
| useUnfilledBets(liveContract.id, { enabled: isOrderBookTabActive }) ?? [] | ||
|
|
||
| if (orderBookTabIndex >= 0) { |
There was a problem hiding this comment.
what is this? Why isn't the order book simply in the tabs array as the content object?
There was a problem hiding this comment.
hmm I'm confused I thought this as well as the clause u asked about above in a comment made up the logic that makes it so useUnfilledBets only gets the unfilledbets once the conditions are met and prevent them from loading with the page
There was a problem hiding this comment.
if totalBets>0, a tab.title === 'Order book' is in the tabs, and therefore the orderBookTabIndex.content is set to the <OrderBookPanel/>, so really the only useful clause is if the totalBets is >0, so why not just stick the orderbookpanel in the tabs? and the unfilled bets will either be empty or full if the hook is enabled (aka the orderBookTabActive)
One thing to note is that logged out mobile users still can't see the orderbook. This was an intentional choice as there wasn't a good spot to put it and I don't think a logged out mobile user cares that much.
Signed out desktop users, non-eligible sweeps signed-in desktop users, and non-eligible sweeps signed-in mobile users can now see the orderbook (although this is limited to binary markets rn - which should be fine since those are the only sweeps markets).