-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add memory monitoring to livereduce #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I appreciate the extra information in the README for configuring this option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Ref: 6960: [LIVEREDUCTION] Add memory monitoring
It works by creating function running in it's own thread that is checking the memory usage. If it gets above the set percentage it will stop live data, clear the workspaces and restart live data. This seemed like a better solution then running mantid in a subprocess, MonitorLiveData is already running in it's own thread anyway.
To test I created another example in the test folder using
FakeISISEventDAE
where it's producing lots of events and the proceeding will just accumulated all the events quickly using up the available memory.Start the fake server
start livereduce
and you should see live data getting restarted after it uses 25% of your memory.