Add unit tests for analysis_reduction #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restructured the functions of the analysis reduction and added two unit tests, one for calculating the kinematics and the other for calculating y spaces.
Added test for 3 different spectra: one with normal data, one with a range in TOF masked with zeros and another fully masked spectra. Checked that the fitting function (total ncp) and fitting parameters match.
Added unit test that compares masking tof range with zeros with using a range that has been cut off (i.e. does not include the values with zeros). If the error function is successfully ignoring zeros then the result of both fits should be the same
GuiMacielPereira
force-pushed
the
add-analysis-reduction-tests
branch
from
ffa62f6
to
912f46e
Compare
Cleaned the code for setting kinematic arrays and fixed unit tests
This unit test tests the fit function itself, rather than the fitting engine
Instead of hard-coded values it's better to compare the ncp fit to synthetic (original) ncp to make sure that optimizer is working correctly
Took out calculation of resolution function for lorentzian out of fit. Cleaned error function and added unit test that checks cases when errors are present and not present.
Cleaned function for calculating means in the reduction analysis and added unit test to check the filtering of widths and intensities is working. I removed all of the assertions because instead of stoping the code it's best to at least keep going and produce the table for means so that at least the user can have a clue for what happened.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work:
Added unit tests for the most important functions in
analysis_reduction.py.I restructured some functions and renamed variables as I added each test.
The functions that I tested are the ones doing all of the mathematical computations, namely the neutron compton fits, the calculation of the kinematics and resolution and finally the calculation of means and standard deviations of the widths and intensities.
Mostly of the functions left to test are about creating workspaces, saving documents, masking and MS and Gamma corrections.
To test:
Code review.
Check that all tests (unit + system) pass.
Fixes #9.