R4R: DTL stop sync TransactionEnqueued event once DTL_SHUTOFF_BLOCK is set #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelliumnt
changed the title
guoshijiang
previously approved these changes
Aug 28, 2023
| @@ -27,6 +27,7 @@ export interface L1DataTransportServiceOptions { | |||
| l2RpcProvider: string | |||
| l2RpcProviderUser?: string | |||
| l2RpcProviderPassword?: string | |||
| l1SyncShutoffBlock?: number | |||
There was a problem hiding this comment.
maybe we should make it configable?: https://github.com/ethereum-optimism/optimism/blob/df11f76b08a70c5a084f2d726d54ba4aa27bb7cc/packages/data-transport-layer/src/services/run.ts#L32
Sha3nS
previously approved these changes
Aug 28, 2023
abelliumnt
force-pushed
the
lhy/dtl-bedrock-shutoff
branch
from
85abead
to
faba895
Compare
wukongcheng
approved these changes
Sep 14, 2023
guoshijiang
approved these changes
Sep 14, 2023
Sha3nS
approved these changes
Sep 14, 2023
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals of PR
Core changes: