[R4R]-{estimateGas}feature: EstimateGas performance optimization #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tri-stone
reviewed
Feb 5, 2024
internal/ethapi/api.go
Outdated
| @@ -21,6 +21,7 @@ import ( | |||
| "encoding/hex" | |||
| "errors" | |||
| "fmt" | |||
| "github.com/ethereum/go-ethereum/consensus" | |||
Tri-stone
changed the title
Tri-stone
reviewed
Feb 5, 2024
.gitignore
Outdated
| @@ -49,3 +49,4 @@ profile.cov | |||
| /dashboard/assets/package-lock.json | |||
|
|
|||
| **/yarn-error.log | |||
| node_modules | |||
Tri-stone
changed the title
boz14676
changed the title
Tri-stone
reviewed
Feb 20, 2024
Tri-stone
reviewed
Feb 20, 2024
| "encoding/json" | ||
| "errors" | ||
| "github.com/ethereum/go-ethereum" |
boz14676
force-pushed
the
zhangbo/optimize_estimate_gas
branch
3 times, most recently
from
c2631f7
to
318a5a7
Compare
feature: Optimize GasEstimate method [R4R]-[estimateGas]feat: enlarge a buffer for Estimation feature: Optimize GasEstimate method feature: Optimize GasEstimate method feature: Optimize GasEstimate method02
boz14676
force-pushed
the
zhangbo/optimize_estimate_gas
branch
from
318a5a7
to
9bab5f8
Compare
boz14676
changed the title
boz14676
changed the title
byteflyfunny
approved these changes
Mar 3, 2024
asdv23
reviewed
Mar 6, 2024
| state, header, err := b.StateAndHeaderByNumberOrHash(ctx, blockNrOrHash) | ||
| if state == nil || err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
Is there a situation where has state == nil && err == nil? If so, the caller may get a NullPointerException due to err == nil and using result(nil).xxx(). If not, just using err!=nil is enough, since state ==nil err must !=nil
Tri-stone
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EstimateGas performance optimization:
Reference：https://github.com/ethereum/go-ethereum/blob/master/eth/gasestimator/gasestimator.go#L52