Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R4R]-feat: merge from release to main; fix some audits #72

Merged
merged 44 commits into from
Mar 14, 2024
Merged

[R4R]-feat: merge from release to main; fix some audits #72

merged 44 commits into from
Mar 14, 2024

Conversation

Tri-stone
Copy link

@Tri-stone Tri-stone commented Mar 14, 2024 •
edited
Loading

Core changes:

  • compatible with 4844
  • fix some issues from audits

abelliumnt and others added 30 commits January 29, 2024 11:16
@abelliumnt @Tri-stone
R4R: compatible with 4844 (#34)
77b7f84 
* compatiable with 4844

* [WIP]-[4844]feat: fix tx receipt

* update holiman uint256 version

* update gen_receipt_json.go

---------

Co-authored-by: LeoZhang <njustzhangl@163.com>
@Tri-stone
Merge pull request #36 from mantlenetworkio/release/v0.5.0
97be26d 
[R4R]-feat: merge from release to develop
Core changes:
    - fee collection & estimataGas
    - eth_getLogs and eth_getBlockByNumber
    - BaseFee & PUSH0 upgrade
    - compatible with 4844
@abelliumnt
R4R: mint eth to msg.from and transfer revertable (#31)
d120ff2
MetaTxSignData add fromAddr, signHash includes this field
3645f7b
metaTxSignData fork with metaTxUpdateHeight
244fc78
change var name
21cfd30
metatx upgrade with config
25af21f
set metatx upgrade blkNum 2744121
23a74e2
update func name IsMetaTxUpgraded to IsMetaTxV2
020aff6
metatxV2 upgrade by timestamp
eb6b730
add rules into TransactionToMessage params, set metaTxUpgradeTime nil
1536797
del metatx upgradeTime from mainnet config
86ac3fd
del useless config
74937cb
IsMetaTxV2 func use isTimestampForked instead of isMetaTxForked
19660a8
validateTx reject BlobTxType txs, Receipt.MarshalJSON check Effective…
8824dc5 
…GasPrice and BlobGasPrice
@wwqicode-blkchain
Merge pull request #37 from mantlenetworkio/wwq/metatx-signFromAddr
4d05b2c 
R4R: metatx add from field into MetaTxSignData, so that to sign hash with from's addr
@Tri-stone
[R4R]feat: add error message when failing to forward tx to sequencer (#…
d12aec3 
…39)

* [R4R]-[SenndTx]feat: add error message when failing to forward tx to sequencer
@Tri-stone
[R4R]-[tx]feat: fix tx cost (#41)
52122bd
@abelliumnt
add balance check for transferring bvm ethTxValue
0cf00ba
@abelliumnt
fix incorrect balance check
72e4779
@abelliumnt
fix incorrectly calculation of the user balance
f636735
@abelliumnt
sponsor percent should be more than zero
b5ea92b
@Tri-stone
Merge pull request #47 from mantlenetworkio/release/v0.5.0
b2cb932 
[R4R]-feat: merge from release/v0.5.0 to develop
Core changes:
- [R4R]feat: mint eth to msg.from and transfer revertable #31
- [R4R]feat: metatx add from field into MetaTxSignData, so that to sign hash with from's addr #37
- [R4R]feat: add error message when failing to forward tx to sequencer #39
- [R4R]fix: fix tx cost #41
@Tri-stone
Merge pull request #42 from mantlenetworkio/bugfix/add-check-for-tran…
7ea77b8 
…sferBVMETH

R4R: add balance check for transferring bvm ethTxValue
@Tri-stone
Merge pull request #45 from mantlenetworkio/bugfix/incorrectly-calcul…
5cce695 
…ation-user-balance

R4R: fix incorrectly calculation of the user balance
@Tri-stone
Merge pull request #44 from mantlenetworkio/bufix/incorrect-balance-c…
a1734e5 
…heck

R4R: incorrect balance check
@Tri-stone
Merge pull request #46 from mantlenetworkio/bugfix/sponsor-percent-mo…
64996df 
…re-than-zero

R4R: sponsor percent should be more than zero
@DevDynamo2024
[R4R]-{estimateGas}feature: EstimateGas performance optimization (#38)
bb4117b 
* feature: Optimize GasEstimate method
@asdv23
Migrate GetBlockRange to op-geth (#48)
a209406
@asdv23
Set SuggestTipCap to zero (#49)
556ba3f
abelliumnt and others added 14 commits March 6, 2024 17:15
@abelliumnt
check accumulated sponsor amount (#43)
5fb5758
@Tri-stone
[R4R]-[L04]-fix: fix balanceCheck for shared pointer (#52)
a442ea7 
* [R4R]-bug: fix balanceCheck for shared pointer
@asdv23
[R4R]-fix: N-09 Unnecessary Double Check of SponsorPercent (#57)
b8cdd4b 
* [R4R]-fix: N-09 Unnecessary Double Check of SponsorPercent
@asdv23
R4R: fix/ivan/L-01 Incorrect Error Message (#50)
3857979
@asdv23
[R4R]-fix: N-06 Inexplicit Struct Declaration (#55)
e3e9399
@asdv23
R4R: fix_N-05 Unused Variables (#54)
0bd29f8
@asdv23
[R4R]-feature: ethclient: use 'input', not 'data' as field for transa…
2eaa043 
…ction input (#59)
@Tri-stone
Merge pull request #60 from mantlenetworkio/audits
8ae3d1f 
R4R-feat: fix some audits
@abelliumnt
increase accumulated sponsor fee (#62)
468d164
@abelliumnt
fix balance check in tx replacement for metatx
b17e053
@idyllsss
Merge pull request #63 from mantlenetworkio/bugfix/replacement-sum-check
f458046 
R4R: fix balance check in tx replacement for metatx
@Tri-stone
Revert "[R4R]-{estimateGas}feature: EstimateGas performance optimizat…
db24062 
…ion (#38)" (#66)

This reverts commit bb4117b.
@Tri-stone
[R4R]-[fee]fix: fix estimateGas; discard invalid tx (#67)
4d49b52
@shidaxi
fix workflow go version (#70)
74e3b45
@Tri-stone Tri-stone changed the title [R4R]-feat: fix some audits [R4R]-feat: merge from release to main; fix some audits Mar 14, 2024
@Tri-stone Tri-stone merged commit 6bf71bf into main Mar 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idyllsss idyllsss idyllsss approved these changes

@byteflyfunny byteflyfunny byteflyfunny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Tri-stone @byteflyfunny @idyllsss @abelliumnt @wwqicode-blkchain @DevDynamo2024 @asdv23 @shidaxi