R4R: metatx bugfix #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pandainzoo <gary.zhu@mantle.xyz>
asdv23
previously approved these changes
May 22, 2024
abelliumnt
previously approved these changes
May 22, 2024
Signed-off-by: pandainzoo <gary.zhu@mantle.xyz>
Signed-off-by: pandainzoo <gary.zhu@mantle.xyz>
Signed-off-by: pandainzoo <gary.zhu@mantle.xyz>
Signed-off-by: pandainzoo <gary.zhu@mantle.xyz>
Signed-off-by: pandainzoo <gary.zhu@mantle.xyz>
Signed-off-by: pandainzoo <gary.zhu@mantle.xyz>
Signed-off-by: pandainzoo <gary.zhu@mantle.xyz>
adam-xu-mantle
previously approved these changes
Jun 7, 2024
pandainzoo
dismissed
adam-xu-mantle’s stale review
The merge-base changed after approval.
abelliumnt
reviewed
Jun 11, 2024
| BaseFeeTime: u64Ptr(0), | ||
| BVMETHMintUpgradeTime: u64Ptr(0), | ||
| MetaTxV2UpgradeTime: u64Ptr(0), | ||
| MetaTxV3UpgradeTime: u64Ptr(1717689600), |
There was a problem hiding this comment.
Is this timestamp suitable for QA3 network?
There was a problem hiding this comment.
yes, the upgrade of QA3 has been completed
abelliumnt
reviewed
Jun 11, 2024
| BaseFeeTime: u64Ptr(0), | ||
| BVMETHMintUpgradeTime: u64Ptr(0), | ||
| MetaTxV2UpgradeTime: u64Ptr(0), | ||
| MetaTxV3UpgradeTime: u64Ptr(1716962400), |
There was a problem hiding this comment.
this is QA9, already upgrade
|
No other comment. |
Tri-stone
previously approved these changes
Jun 17, 2024
pandainzoo
dismissed
Tri-stone’s stale review
The merge-base changed after approval.
Tri-stone
approved these changes
Jun 17, 2024
adam-xu-mantle
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core changes:
1. ensure sponsor doesn't equal to tx sender
2. fix metatx estimateGas
3. fix metatx gas undercharge
4. optimize tx estimateGas check