-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add attribute driver & remove annotations support #124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work ! 👌
There are some small things to change regarding naming.
Can you also document the CHANGELOG.md file ?
As this will require a major bump as this is a breaking change, can you document the migration path for users ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this interface ? It seems unused, no ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This interface still seems useless, never tested anywhere, and empty. Can we remove that ?
AbstractPropertyAttribute
and AbstractClassAttribute
does implements them, and they seems nearly as useless (just to make phpstan happy, no ?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MappingAttribute
interface has been deleted since.
I can delete abstract classes too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
623eb56
to
dd34614
Compare
doctrine/annotations
dependency (i was thinking about keeping them but thought this seemed pretty useless to have both because Annotations are not so PHP8 friendly)AnnotationDriver
but handling attributes using Reflection. (its just a basic copy paste with some adjustments ofc)Rest\Attribute
attribute$type
parameter, for adding strict typing