Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route notifications #807

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Route notifications #807

wants to merge 4 commits into from

Conversation

Udumft
Copy link
Contributor

@Udumft Udumft commented Apr 6, 2023

Adds parsing 'beta' parameters regarding requesting and receiving route notifications about restrictions violations.

Added RouteLeg.Notification types and coding; Added AttributeOptions to receive notifications
@Udumft Udumft self-assigned this Apr 6, 2023
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #807 (7b12dc2) into main (9714ec6) will increase coverage by 0.37%.
The diff coverage is 96.17%.

❗ Current head 7b12dc2 differs from pull request most recent head 4dc99c4. Consider uploading reports for the commit 4dc99c4 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #807      +/-   ##
==========================================
+ Coverage   84.26%   84.63%   +0.37%     
==========================================
  Files          59       60       +1     
  Lines        4888     5045     +157     
==========================================
+ Hits         4119     4270     +151     
- Misses        769      775       +6     
Impacted Files Coverage Δ
Sources/MapboxDirections/AttributeOptions.swift 86.58% <60.00%> (-1.73%) ⬇️
Sources/MapboxDirections/RouteNotification.swift 97.22% <97.22%> (ø)
Sources/MapboxDirections/RouteLeg.swift 87.55% <100.00%> (+0.42%) ⬆️

accepted breaking changes
@Udumft Udumft marked this pull request as ready for review April 6, 2023 12:53
@Udumft Udumft marked this pull request as draft April 6, 2023 12:56
@Udumft Udumft requested a review from a team April 6, 2023 12:57
Changed requesting notifications from annotations type to separate parameter; Unit tests updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant