Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trivialwizard6 #66

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Add trivialwizard6 #66

merged 1 commit into from
Nov 11, 2024

Conversation

rcalixte
Copy link
Contributor

@rcalixte rcalixte commented Nov 10, 2024

This uses Qt6 QWizardPage instances to create a sample introductory wizard for an application.

This is ported from:
https://github.com/jimmykuu/therecipe-qt-examples/blob/master/widgets/dialogs/trivialwizard/trivialwizard.go

@rcalixte
Copy link
Contributor Author

Would it makes sense to move the examples to a dedicated repository and link to them from the README or as a git submodule? I want to flesh out the Qt6 examples so I expect to contribute more of them but it might also help other developers onboard with this toolkit.

This uses Qt6 QWizardPage instances to create a sample introductory wizard for
an application.

This is ported from:
https://github.com/jimmykuu/therecipe-qt-examples/blob/master/widgets/dialogs/trivialwizard/trivialwizard.go
@mappu
Copy link
Owner

mappu commented Nov 11, 2024

Nice, the example looks great.

Would it makes sense to move the examples to a dedicated repository and link to them from the README or as a git submodule?

I'm happy either way.

  • One reason to keep some examples in this repo is so that CI can compile them, to avoid breakage. This is especially important as MIQT is still not yet v1.0.0.
  • One reason to split to another repo, is the ability to port examples with a wider variety of licenses. It's great to port from jimmykuu/therecipe-qt-examples, but because code in therecipe/qt is LGPL, we could only port some small trivial things to avoid copyright infringement. But in a new repo with a different license, that would definitely not be a problem.

@mappu mappu merged commit 0b16793 into mappu:master Nov 11, 2024
5 checks passed
@mappu
Copy link
Owner

mappu commented Nov 11, 2024

Test screenshot

image

@rcalixte rcalixte deleted the trivialwizard6 branch November 11, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants