Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geocoding API update #41

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Geocoding API update #41

merged 1 commit into from
Apr 18, 2024

Conversation

zdila
Copy link
Contributor

@zdila zdila commented Apr 18, 2024

Objective

  • Added matching_text and matching_place_name properties to geocoding feature response
  • Added road to geocoding types

Description

Updated types.

Checklist

  • I have added relevant info to the CHANGELOG.md

@zdila zdila requested review from jonathanlurie, bolollo and a team April 18, 2024 10:22
petrsloup
petrsloup approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@petrsloup petrsloup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@zdila zdila merged commit f5b81da into main Apr 18, 2024
1 check passed
@zdila zdila deleted the GO-384-geocoding-api-update branch April 18, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrsloup petrsloup petrsloup approved these changes

@jonathanlurie jonathanlurie Awaiting requested review from jonathanlurie

@bolollo bolollo Awaiting requested review from bolollo

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zdila @petrsloup